mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Kan Liang <kan.liang@intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, a.p.zijlstra@chello.nl,
	luto@kernel.org, mingo@redhat.com, eranian@google.com,
	ak@linux.intel.com, mark.rutland@arm.com,
	adrian.hunter@intel.com, namhyung@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 6/7] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat
Date: Thu, 27 Aug 2015 20:10:46 +0200	[thread overview]
Message-ID: <20150827181045.GD25932@krava.redhat.com> (raw)
In-Reply-To: <1440494288-20448-7-git-send-email-kan.liang@intel.com>

On Tue, Aug 25, 2015 at 05:18:07AM -0400, Kan Liang wrote:
> From: Kan Liang <kan.liang@intel.com>
> 
> Caculate freq/CPU%/CORE_BUSY% in add_entry_cb, and update the value in
> he_stat.
> 
> Signed-off-by: Kan Liang <kan.liang@intel.com>
> ---
>  tools/perf/builtin-report.c | 36 ++++++++++++++++++++++++++++++++++++
>  tools/perf/util/sort.h      |  3 +++
>  2 files changed, 39 insertions(+)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 62b285e..1bc74acd 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -89,6 +89,38 @@ static int report__config(const char *var, const char *value, void *cb)
>  	return perf_default_config(var, value, cb);
>  }
>  
> +static void set_he_freq_perf(struct perf_session *session,
> +			     struct hist_entry_iter *iter)
> +{
> +	struct hist_entry *he = iter->he;
> +	struct perf_evsel *evsel = iter->evsel;
> +	struct perf_evsel *leader = evsel;
> +	struct perf_sample *sample = iter->sample;
> +	struct perf_evlist *evlist = session->evlist;
> +	u64 cpu_max_freq = session->header.env.cpu_attr[PERF_HEADER_CPU_MAX_FREQ];

so why not access the cpu_attr.freq ?

jirka

  reply	other threads:[~2015-08-27 18:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  9:18 [PATCH V5 0/7] Freq/CPU%/CORE_BUSY% support Kan Liang
2015-08-25  9:18 ` [PATCH V5 1/7] perf,tools: introduce generic FEAT for CPU attributes Kan Liang
2015-08-27 17:54   ` Jiri Olsa
2015-08-27 18:10   ` Jiri Olsa
2015-08-25  9:18 ` [PATCH V5 2/7] perf,tools: read msr pmu type from header Kan Liang
2015-08-25  9:18 ` [PATCH V5 3/7] perf,tools: rename perf_session_env and add backpointer to evlist Kan Liang
2015-08-25  9:18 ` [PATCH V5 4/7] perf evsel: Add a backpointer to the evlist a evsel is in Kan Liang
2015-08-25  9:18 ` [PATCH V5 5/7] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Kan Liang
2015-08-25  9:18 ` [PATCH V5 6/7] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat Kan Liang
2015-08-27 18:10   ` Jiri Olsa [this message]
2015-08-25  9:18 ` [PATCH V5 7/7] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150827181045.GD25932@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome