mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: klimov.linux@gmail.com
Cc: aleksey.makarov@auriga.com, netdev@vger.kernel.org,
	rric@kernel.org, david.daney@cavium.com,
	Sunil.Goutham@caviumnetworks.com,
	aleksey.makarov@caviumnetworks.com, linux-kernel@vger.kernel.org,
	rrichter@cavium.com, robert.richter@caviumnetworks.com,
	sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 7/8] net: thunderx: Support for upto 96 queues for a VF
Date: Fri, 28 Aug 2015 22:10:49 -0700 (PDT)	[thread overview]
Message-ID: <20150828.221049.256686243264204039.davem@davemloft.net> (raw)
In-Reply-To: <CALW4P+KVjSFA3F+9wHTMiyMHkFjrbedP2LpUu033-o0k32F0nw@mail.gmail.com>

From: Alexey Klimov <klimov.linux@gmail.com>
Date: Sat, 29 Aug 2015 04:45:03 +0300

>> @@ -717,9 +833,24 @@ static void nic_unregister_interrupts(struct nicpf *nic)
>>         nic_disable_msix(nic);
>>  }
>>
>> +static int nic_num_sqs_en(struct nicpf *nic, int vf_en)
>> +{
>> +       int pos = 0, sqs_per_vf = MAX_SQS_PER_VF_SINGLE_NODE;
> 
> Please check if you really need to initialize 'pos' by zero here.

Please do _NOT_ quote hundreds of lines of code only to give feedback
on one particular hunk.

Quote _ONLY_ the exact context required, nothing more.

Everyone has to scroll through all of this unrelated crap you quoted,
and that makes more work for everyone.

Think particularly of _ME_ who has to be aware of what's going on in
every discussion thread for every patch that gets posted to this list.

  reply	other threads:[~2015-08-29  5:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 14:59 [PATCH net-next 1/8] net: thunderx: fix MAINTAINERS Aleksey Makarov
2015-08-28 14:59 ` [PATCH net-next 2/8] net: thunderx: Add receive error stats reporting via ethtool Aleksey Makarov
2015-08-28 14:59 ` [PATCH net-next 3/8] net: thunderx: mailboxes: remove code duplication Aleksey Makarov
2015-08-28 14:59 ` [PATCH net-next 4/8] net: thunderx: Receive hashing HW offload support Aleksey Makarov
2015-08-28 14:59 ` [PATCH net-next 5/8] net: thunderx: Support for HW VLAN stripping Aleksey Makarov
2015-08-28 14:59 ` [PATCH net-next 6/8] net: thunderx: Rework interrupt handler Aleksey Makarov
2015-08-28 21:26   ` David Miller
2015-08-28 14:59 ` [PATCH net-next 7/8] net: thunderx: Support for upto 96 queues for a VF Aleksey Makarov
2015-08-29  1:45   ` Alexey Klimov
2015-08-29  5:10     ` David Miller [this message]
2015-08-28 15:00 ` [PATCH net-next 8/8] net: thunderx: Support for internal loopback mode Aleksey Makarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828.221049.256686243264204039.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Sunil.Goutham@caviumnetworks.com \
    --cc=aleksey.makarov@auriga.com \
    --cc=aleksey.makarov@caviumnetworks.com \
    --cc=david.daney@cavium.com \
    --cc=klimov.linux@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robert.richter@caviumnetworks.com \
    --cc=rric@kernel.org \
    --cc=rrichter@cavium.com \
    --cc=sgoutham@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®