From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
Matt Fleming <matt.fleming@intel.com>,
linux-efi@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>
Subject: Re: [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per arch.
Date: Fri, 28 Aug 2015 09:39:41 +0100 [thread overview]
Message-ID: <20150828083941.GN10728@bivouac.eciton.net> (raw)
In-Reply-To: <20150828062745.GB1928@gmail.com>
On Fri, Aug 28, 2015 at 08:27:45AM +0200, Ingo Molnar wrote:
>
> * Andrey Ryabinin <ryabinin.a.a@gmail.com> wrote:
>
> > In not-instrumented code KASAN replaces instrumented
> > memset/memcpy/memmove with not-instrumented analogues
> > __memset/__memcpy/__memove.
> > However, on x86 EFI stub is not linked with kernel.
>
> s/with the kernel
>
> > It uses not-instrumented mem*() functions from
> > arch/x86/boot/compressed/string.c
> > So we don't replace them with __mem*() variants in EFI stub.
> >
> > In ARM64 EFI stub is linked with the kernel, so we should
>
> s/In ARM64 EFI stub/On ARM64 the EFI stub/.
>
> > replace mem*() functions with __mem*(), because EFI stub
>
> s/the EFI stub
>
> > runs before KASAN setup early shadow.
>
> s/before KASAN sets up the early shadow
>
> ?
>
> > So let's move these #undef mem* into arch's asm/efi.h which is
>
> s/lets
No, that one is actually correct. Abbreviation of let us.
> > also included by EFI stub.
>
> s/by the EFI stub
>
> >
> > Signed-off-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
> > ---
> > arch/x86/include/asm/efi.h | 8 ++++++++
> > drivers/firmware/efi/libstub/efistub.h | 4 ----
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
> > index 155162e..d821ce2 100644
> > --- a/arch/x86/include/asm/efi.h
> > +++ b/arch/x86/include/asm/efi.h
> > @@ -25,6 +25,14 @@
> > #define EFI32_LOADER_SIGNATURE "EL32"
> > #define EFI64_LOADER_SIGNATURE "EL64"
> >
> > +/*
> > + * Use memcpy/memset from arch/x86/boot/compressed/string.c
> > + * for EFI stub.
> > + */
> > +#undef memcpy
> > +#undef memset
> > +#undef memmove
>
> This comment should also mention why it's done, not what is done.
>
> Also:
>
> s/for EFI stub/for the EFI stub
>
> Thanks,
>
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-efi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-28 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 16:15 [PATCH 0/4] KASAN/ARM64 EFI fixes Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per arch Andrey Ryabinin
2015-08-28 6:27 ` Ingo Molnar
2015-08-28 8:39 ` Leif Lindholm [this message]
2015-08-28 9:53 ` Ingo Molnar
2015-08-28 11:09 ` [PATCH v2] " Andrey Ryabinin
2015-08-28 14:43 ` Matt Fleming
2015-08-28 14:57 ` Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 2/4] efi/runtime-wrappers, kasan: don't sanitize runtime wrappers Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 3/4] arm64/efi-stub, kasan: don't instrument efi-stub Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 4/4] libfdt, kasan: don't instrument libfdt Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828083941.GN10728@bivouac.eciton.net \
--to=leif.lindholm@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®