From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753344AbbHaPNJ (ORCPT ); Mon, 31 Aug 2015 11:13:09 -0400 Received: from smtprelay0028.hostedemail.com ([216.40.44.28]:47159 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752807AbbHaPNI (ORCPT ); Mon, 31 Aug 2015 11:13:08 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:3874:5007:6261:7875:8957:9040:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: shock05_8f6ab94272c53 X-Filterd-Recvd-Size: 2172 Date: Mon, 31 Aug 2015 11:13:04 -0400 From: Steven Rostedt To: Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim , Ingo Molnar , Mel Gorman , David Rientjes Subject: Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to userspace Message-ID: <20150831111304.3888a8f6@gandalf.local.home> In-Reply-To: <55E46C8E.8070906@suse.cz> References: <1440689044-2922-1-git-send-email-vbabka@suse.cz> <1440689044-2922-2-git-send-email-vbabka@suse.cz> <20150831105834.34a5e69e@gandalf.local.home> <55E46C8E.8070906@suse.cz> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2015 17:02:38 +0200 Vlastimil Babka wrote: > >> +#define ZONE_TYPE \ > >> + IFDEF_ZONE_DMA( EM (ZONE_DMA, "DMA")) \ > >> + IFDEF_ZONE_DMA32( EM (ZONE_DMA32, "DMA32")) \ > >> + EM (ZONE_NORMAL, "Normal") \ > >> + IFDEF_ZONE_HIGHMEM( EM (ZONE_HIGHMEM,"HighMem")) \ > >> + EMe(ZONE_MOVABLE,"Movable") > >> + > > > > Hmm, have you tried to compile this with CONFIG_ZONE_HIGHMEM disabled, > > and CONFIG_ZONE_DMA and/or CONFIG_ZONE_DMA32 enabled? > > Yep, that's standard x86_64 situation (highmem disabled, dma+dma32 enabled). > > > The EMe() macro must come last, as it doesn't have the ending comma and > > the __print_symbolic() can fail to compile due to it. > > Thanks to ZONE_MOVABLE being unconditional, EMe(ZONE_MOVABLE...) is > always last. Otherwise the macros would get even more ugly... Ah! My mistake was to see where the end parenthesis of IFDEF_ZONE_HIGHMEM() laid. It looked to me that it encompassed ZONE_MOVABLE. But obviously it does not. -- Steve