From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753217AbbHaPh4 (ORCPT ); Mon, 31 Aug 2015 11:37:56 -0400 Received: from casper.infradead.org ([85.118.1.10]:41589 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752714AbbHaPhz (ORCPT ); Mon, 31 Aug 2015 11:37:55 -0400 Date: Mon, 31 Aug 2015 17:37:49 +0200 From: Peter Zijlstra To: Byungchul Park Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, yuyang.du@intel.com Subject: Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq Message-ID: <20150831153749.GM18673@twins.programming.kicks-ass.net> References: <1440069720-27038-1-git-send-email-byungchul.park@lge.com> <1440069720-27038-6-git-send-email-byungchul.park@lge.com> <20150820113516.GJ24261@byungchulpark-X58A-UD3R> <20150831152138.GO19282@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150831152138.GO19282@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 31, 2015 at 05:21:38PM +0200, Peter Zijlstra wrote: > + if (!p->se.on_rq) > return true; > > return false; > > > Does that make sense? It does not.. never mind me.