From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754421AbbHaTp1 (ORCPT ); Mon, 31 Aug 2015 15:45:27 -0400 Received: from smtprelay0028.hostedemail.com ([216.40.44.28]:50865 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752337AbbHaTpZ (ORCPT ); Mon, 31 Aug 2015 15:45:25 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4385:5007:6119:6261:7875:7903:10004:10400:10848:10967:11232:11658:11914:12517:12519:12663:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: tank55_2f2552d1cf454 X-Filterd-Recvd-Size: 1775 Date: Mon, 31 Aug 2015 15:45:21 -0400 From: Steven Rostedt To: Scott Wood Cc: Dave Chinner , , , Subject: Re: [PATCH 21/22] xfs: %pF is only for function pointers Message-ID: <20150831154521.1c9353b6@gandalf.local.home> In-Reply-To: <1441049065.4966.38.camel@freescale.com> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-21-git-send-email-scottwood@freescale.com> <20150831080657.GF26895@dastard> <1441049065.4966.38.camel@freescale.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2015 14:24:25 -0500 Scott Wood wrote: > > Can you please look into why this change broke the tracing output > > on x86-64 - if there is no obvious/easy fix for it, then I'm simply > > going to revert it because having the tracing work correctly on > > x86-64 is far more important to us than ppc64 or ia64.... > > It looks like the cause is that TP_printk() is not really printk() -- it > actually passes the format to userspace which has its own, not 100% > compatible implementation pretty_print() in tools/lib/traceevent/event- > parse.c. %pf in that function behaves like %ps in the kernel, and %ps is > absent. > We can fix that with adding %ps to the traceevent library. -- Steve