From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816AbbIAPcj (ORCPT ); Tue, 1 Sep 2015 11:32:39 -0400 Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:34189 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752308AbbIAPch (ORCPT ); Tue, 1 Sep 2015 11:32:37 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3874:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12296:12517:12519:12740:13069:13161:13229:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: wool25_50df2d2920538 X-Filterd-Recvd-Size: 1567 Date: Tue, 1 Sep 2015 11:32:34 -0400 From: Steven Rostedt To: Sasha Levin Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename Message-ID: <20150901113234.53c1da70@gandalf.local.home> In-Reply-To: <55E5BF34.8080005@oracle.com> References: <1440760018-1557-1-git-send-email-sasha.levin@oracle.com> <20150828110251.41b6b805@gandalf.local.home> <55E5BF34.8080005@oracle.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 01 Sep 2015 11:07:32 -0400 Sasha Levin wrote: > > Also, as the memcpy was just faster than a strcpy, the static length > > was used. Perhaps we should convert that to a dynamic length string. > > But that should be a separate patch as this one fixes a possible bug, > > and the conversion to a dynamic string is just an enhancement. > > That'll slow things down for the common case, no? Not really that much. The comms should have been dynamic strings too, but the sched_switch tracepoint (the one others have been copied from) was created before we had dynamic strings for tracepoints. -- Steve