From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbbIANub (ORCPT ); Tue, 1 Sep 2015 09:50:31 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:47426 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbbIANua (ORCPT ); Tue, 1 Sep 2015 09:50:30 -0400 Date: Tue, 1 Sep 2015 21:50:19 +0800 From: Herbert Xu To: tgraf@suug.ch, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, fengguang.wu@intel.com, wfg@linux.intel.com, lkp@01.org Subject: Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads Message-ID: <20150901135019.GA13629@gondor.apana.org.au> References: <20150829090701.GN20760@orbit.nwl.cc> <20150830074717.GA25396@gondor.apana.org.au> <20150831110012.GO20760@orbit.nwl.cc> <20150901114300.GB12691@gondor.apana.org.au> <20150901124648.GA27550@orbit.nwl.cc> <20150901130057.GA13230@gondor.apana.org.au> <20150901134310.GB27550@orbit.nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150901134310.GB27550@orbit.nwl.cc> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2015 at 03:43:11PM +0200, Phil Sutter wrote: > > Hmm. Since memory allocation is first tried with GFP_ATOMIC set and upon > failure retried in background, this seems like a situation which might > happen during normal use. If that already indicates a severe problem, > why retry in background at all? It should be tried in the background first at 70% and only when that fails would we hit the 100% case and then we will try it with GFP_ATOMIC. If that fails then the insertion will fail. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt