From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754077AbbIAPzv (ORCPT ); Tue, 1 Sep 2015 11:55:51 -0400 Received: from mail.skyhub.de ([78.46.96.112]:58752 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbbIAPzu (ORCPT ); Tue, 1 Sep 2015 11:55:50 -0400 Date: Tue, 1 Sep 2015 17:56:00 +0200 From: Borislav Petkov To: Guenter Roeck Cc: Peter Zijlstra , Ingo Molnar , Huang Rui , Borislav Petkov , Jean Delvare , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , "Rafael J. Wysocki" , Len Brown , John Stultz , =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, x86@kernel.org, Andreas Herrmann , Aravind Gopalakrishnan , Fengguang Wu , Aaron Lu , Tony Li Subject: Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit Message-ID: <20150901155600.GA8497@nazgul.tnic> References: <1440662866-28716-10-git-send-email-ray.huang@amd.com> <20150828064814.GB20153@nazgul.tnic> <20150828080418.GB13309@gmail.com> <20150829091914.GA8878@gmail.com> <20150830155322.GA26370@nazgul.tnic> <20150831083821.GE16853@twins.programming.kicks-ass.net> <20150831160622.GA29830@nazgul.tnic> <55E47E88.7080202@roeck-us.net> <20150831204426.GI16853@twins.programming.kicks-ass.net> <55E4C5F8.6050303@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55E4C5F8.6050303@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 31, 2015 at 02:24:08PM -0700, Guenter Roeck wrote: > That is a matter of driver implementation. Very commonly hwmon drivers > implement value caching, where data from the device is only read at > minimum intervals, and the cached values are reported if the information > is polled too rapidly. I don't see how we can use cached values in that case as they'd be basically a lie as to how much power the CU/processor has consumed. I guess it would be fairer to the user to warn instead and not issue any values or to simply delay the read to a min timeout... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --