From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121AbbIASsl (ORCPT ); Tue, 1 Sep 2015 14:48:41 -0400 Received: from mga03.intel.com ([134.134.136.65]:38960 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752786AbbIASsk (ORCPT ); Tue, 1 Sep 2015 14:48:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,450,1437462000"; d="scan'208";a="796029046" Date: Tue, 1 Sep 2015 11:48:39 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , linux-kernel@vger.kernel.org, jolsa@kernel.org Subject: Re: [PATCH] perf, tools: Always use non inlined file name for srcfile Message-ID: <20150901184839.GA4524@tassilo.jf.intel.com> References: <1441131102-28331-1-git-send-email-andi@firstfloor.org> <20150901183657.GG29821@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150901183657.GG29821@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2015 at 03:36:57PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 01, 2015 at 11:11:42AM -0700, Andi Kleen escreveu: > > From: Andi Kleen > > > > When profiling the kernel with srcfile it's common to "get > > stuck" in include. For example a lot of code uses current > > or other inlines, so they get accounted to some random > > include file. This is not very useful as a high level > > categorization. > > Cool idea :-) Yes. It would be also nice to use this information for unwinding (so to show the inline stack as part of the call graph) > Why not the so much simpler: > > while (bfd_find_inliner_info(...)); > > But other than that, wouldn't be better to put an upper limit on this? > > Say, 1024 levels of unwinding to avoid tripping in some bfd lib bug that > could make this function always return true and make addr2line get stuck > in an infinite loop? Done. I sent a v2. -Andi -- ak@linux.intel.com -- Speaking for myself only