From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbbIAWOl (ORCPT ); Tue, 1 Sep 2015 18:14:41 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:37354 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbIAWOj (ORCPT ); Tue, 1 Sep 2015 18:14:39 -0400 X-Helo: d03dlp02.boulder.ibm.com X-MailFrom: sukadev@linux.vnet.ibm.com X-RcptTo: sparclinux@vger.kernel.org Date: Tue, 1 Sep 2015 15:11:53 -0700 From: Sukadev Bhattiprolu To: Peter Zijlstra Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces Message-ID: <20150901221153.GB4158@us.ibm.com> References: <1439534981-7937-1-git-send-email-sukadev@linux.vnet.ibm.com> <1439534981-7937-2-git-send-email-sukadev@linux.vnet.ibm.com> <20150901103859.GP19282@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150901103859.GP19282@twins.programming.kicks-ass.net> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15090122-0033-0000-0000-000005B6E97A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra [peterz@infradead.org] wrote: | | when looking at this (I almost pressed A for apply) it occurred to me | that we now keep double state, cpuhw->txn_flags and cpuhw->group_flag | are basically the same thing. | | Would not something like the below avoid this duplication? Yes, it makes sense to drop the duplication. Will similarly drop the usage of PERF_EVENT_TXN from other architectures too and try it out. Thanks, Sukadev