mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, stat: Quieten failed to read counter message
Date: Wed, 2 Sep 2015 08:07:20 +0200	[thread overview]
Message-ID: <20150902060720.GE1978@krava.brq.redhat.com> (raw)
In-Reply-To: <1441147966-14917-1-git-send-email-andi@firstfloor.org>

On Tue, Sep 01, 2015 at 03:52:46PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Since 3b3eb0445 running perf stat on a system without
> backend-stalled-cycles spits out ugly warnings by default. Since that is quite
> common, make the message a debug message only. We know
> anyways that the counter wasn't read by the normal <unsupported>
> output.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/builtin-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index d46dbb1..a96fb5c 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
>  
>  	evlist__for_each(evsel_list, counter) {
>  		if (read_counter(counter))
> -			pr_warning("failed to read counter %s\n", counter->name);
> +			pr_debug("failed to read counter %s\n", counter->name);
>  
>  		if (perf_stat_process_counter(&stat_config, counter))
>  			pr_warning("failed to process counter %s\n", counter->name);
> -- 
> 2.4.3
> 

  reply	other threads:[~2015-09-02  6:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 22:52 Andi Kleen
2015-09-02  6:07 ` Jiri Olsa [this message]
2015-09-02 12:53   ` Arnaldo Carvalho de Melo
2015-09-08 14:32 ` [tip:perf/core] perf " tip-bot for Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2015-08-18 23:15 [PATCH] perf, tools, " Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150902060720.GE1978@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®