From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbbIBIPH (ORCPT ); Wed, 2 Sep 2015 04:15:07 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:50254 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbIBIPD (ORCPT ); Wed, 2 Sep 2015 04:15:03 -0400 Date: Wed, 2 Sep 2015 10:14:56 +0200 From: Peter Zijlstra To: Byungchul Park Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, yuyang.du@intel.com, efault@gmx.de, tglx@linutronix.de Subject: Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq Message-ID: <20150902081456.GQ16853@twins.programming.kicks-ass.net> References: <1440069720-27038-1-git-send-email-byungchul.park@lge.com> <1440069720-27038-6-git-send-email-byungchul.park@lge.com> <20150820113516.GJ24261@byungchulpark-X58A-UD3R> <20150831152138.GO19282@twins.programming.kicks-ass.net> <20150901002849.GA30881@byungchulpark-X58A-UD3R> <20150901150343.GT19282@twins.programming.kicks-ass.net> <20150902023315.GA6455@byungchulpark-X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150902023315.GA6455@byungchulpark-X58A-UD3R> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 11:33:15AM +0900, Byungchul Park wrote: > +++ b/kernel/sched/fair.c > @@ -7920,14 +7920,14 @@ prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio) > > static inline bool vruntime_normalized(struct task_struct *p) > { > struct sched_entity *se = &p->se; > > /* > + * In both TASK_ON_RQ_QUEUED case and TASK_ON_RQ_MIGRATING case, > + * the dequeue_entity(.flags=0) will already have normalized the > + * vruntime. > */ > + if (p->on_rq) > return true; > You're right. And yes this is nicer. Thanks! I've folded it into your 5/5 patch.