From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbbIBNfG (ORCPT ); Wed, 2 Sep 2015 09:35:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33169 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbbIBNfA (ORCPT ); Wed, 2 Sep 2015 09:35:00 -0400 Date: Wed, 2 Sep 2015 15:34:56 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Matt Fleming , =?iso-8859-1?Q?Rapha=EBl?= Beamonte , Steven Rostedt Subject: Re: [PATCH 01/15] perf tools: Fix parse_events_add_pmu caller Message-ID: <20150902133456.GA27164@krava.brq.redhat.com> References: <1441180605-24737-1-git-send-email-jolsa@kernel.org> <1441180605-24737-2-git-send-email-jolsa@kernel.org> <20150902130053.GE12722@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150902130053.GE12722@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 10:00:53AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 02, 2015 at 09:56:31AM +0200, Jiri Olsa escreveu: > > Following commit changed parse_events_add_pmu interface: > > 36adec85a86f perf tools: Change parse_events_add_pmu interface > > > > but forgot to change one caller. Because of lessen compilation > > rules for the bison parser, the compiler did not warn on that. > > Humm, wonder what can be done to improve this situation... No ideas? not really.. :-\ it's generated code, that will fail to compile or spit other loads of warnings if we enable them moving most of the code out of parse-event.y to other objects helps, but thats pretty much what we do now > > Applying to perf/urgent, thanks, jirka