From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754168AbbIBWYe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Sep 2015 18:24:34 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:52004 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751983AbbIBWYd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Sep 2015 18:24:33 -0400
Date: Thu, 3 Sep 2015 00:24:27 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: Warning in irq_work_queue_on()
Message-ID: <20150902222427.GW19282@twins.programming.kicks-ass.net>
References: <20150825001611.GA1751@linux.vnet.ibm.com>
 <20150902194405.GM22326@mtj.duckdns.org>
 <20150902215020.GA21505@lerouge>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150902215020.GA21505@lerouge>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 02, 2015 at 11:50:22PM +0200, Frederic Weisbecker wrote:
> > > [  875.703227]  [<ffffffff810c2d74>] tick_nohz_full_kick_cpu+0x44/0x50
> 
> It happens in nohz full, but I'm not sure the guilty is nohz full.
> 
> The problem here is that wake_up_nohz_cpu() selects a CPU that is offline.

wake_up_nohz_cpu() doesn't do any such thing. Where does the selection
logic live?

> But this shouldn't happen. Either it selects a CPU that is in the domain tree,
> and I suspect offline CPUs aren't supposed to be there, or it selects the current
> CPU. And if the CPU is offlined, it shouldn't be running some kthread...

Do no assume things like that.. always check with the active mask.