From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbbIBNhe (ORCPT ); Wed, 2 Sep 2015 09:37:34 -0400 Received: from ozlabs.org ([103.22.144.67]:39637 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbbIBNhc (ORCPT ); Wed, 2 Sep 2015 09:37:32 -0400 Date: Wed, 2 Sep 2015 23:37:29 +1000 From: Stephen Rothwell To: Roger Willcocks Cc: Jens Axboe , David Jeffery , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Ben Myers , linux-next@vger.kernel.org, Christoph Hellwig Subject: Re: linux-next: manual merge of the block tree with the xfs tree Message-ID: <20150902233729.4e824342@canb.auug.org.au> In-Reply-To: <1441200891.17400.1277.camel@localhost.localdomain> References: <20150902121649.7a686b6c@canb.auug.org.au> <20150902230342.125e23ce@canb.auug.org.au> <1441200891.17400.1277.camel@localhost.localdomain> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On Wed, 02 Sep 2015 14:34:51 +0100 Roger Willcocks wrote: > > Huh, now I've had my coffee, that extra check doesn't add anything. > (There's no harm done in assigning zero to io_error if it's already > zero.) Apologies for the noise. That's OK, my excuse is being to far at the other end of the day ... I actually now remember thinking the same thing at the time I did it :-) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au