mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peng Sun <sironhide0null@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] fix drivers/staging/android several coding style issues
Date: Wed, 2 Sep 2015 18:05:12 -0700	[thread overview]
Message-ID: <20150903010512.GB31349@kroah.com> (raw)
In-Reply-To: <1440561137-15574-1-git-send-email-sironhide0null@gmail.com>

On Wed, Aug 26, 2015 at 11:52:09AM +0800, Peng Sun wrote:
> patches based on linux-next next-20150825
> Corrections based on checkpatch.pl with --strict
> 
> Peng Sun (8):
>   fix staging:android style issue:spaces preferred around that '-'
>   fix staging:android style issue:No space is necessary after a cast
>   fix staging:android style issue:Alignment should match open
>     parenthesis
>   fix staging:android style issue:Prefer kernel type 'u32' over
>     'uint32_t'
>   fix staging:android style issue:Please use a blank line after
>     function/struct/union/enum declarations
>   fix staging:android style issue:Comparison to NULL could be written
>   fix staging:android style issue:definition without comment
>   fix staging:android style issue:Please don't use multiple blank lines

You sent out 3 different series, and I don't know which should be
applied.  So please fix up and resend just the one you want applied.

Note, the "style issue:" shouldn't be in the subject, look at how other
commits are titled.

thanks,

greg k-h

      parent reply	other threads:[~2015-09-03  1:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26  3:52 Peng Sun
2015-08-26  3:52 ` [PATCH 1/8] fix staging:android style issue:spaces preferred around that '-' Peng Sun
2015-08-26  3:52   ` [PATCH 2/8] fix staging:android style issue:No space is necessary after a cast Peng Sun
2015-08-26  3:52     ` [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis Peng Sun
2015-08-26  3:52       ` [PATCH 4/8] fix staging:android style issue:Prefer kernel type 'u32' over 'uint32_t' Peng Sun
2015-08-26  3:52         ` [PATCH 5/8] fix staging:android style issue:Please use a blank line after function/struct/union/enum declarations Peng Sun
2015-08-26  3:52           ` [PATCH 6/8] fix staging:android style issue:Comparison to NULL could be written Peng Sun
2015-08-26  3:52             ` [PATCH 7/8] fix staging:android style issue:definition without comment Peng Sun
2015-08-26  3:52               ` [PATCH 8/8] fix staging:android style issue:Please don't use multiple blank lines Peng Sun
2015-08-26  9:29       ` [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis Giedrius Statkevičius
2015-09-03  1:05 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150903010512.GB31349@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sironhide0null@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®