From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756176AbbICCpq (ORCPT ); Wed, 2 Sep 2015 22:45:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:56786 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755583AbbICCpp (ORCPT ); Wed, 2 Sep 2015 22:45:45 -0400 Date: Thu, 3 Sep 2015 04:45:42 +0200 From: "Luis R. Rodriguez" To: Stuart Hayes Cc: tglx@linutronix.de, mingo@redhat.com, "H. Peter Anvin" , linux-kernel@vger.kernel.org, x86@kernel.org, prarit@redhat.com, mcgrof@do-not-panic.com, Toshi Kani Subject: Re: Fwd: [PATCH] x86: Use larger chunks in mtrr_cleanup Message-ID: <20150903024542.GS8051@wotan.suse.de> References: <55E477DE.2060106@gmail.com> <55E47B4D.1050103@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E47B4D.1050103@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 31, 2015 at 11:05:33AM -0500, Stuart Hayes wrote: > Increase the range of chunk sizes tried in mtrr_cleanup() so it is able > to map large memory configs into MTRRs. > > Currently, mtrr_cleanup() will fail with large memory configurations, > because it limits chunk_size to 2GB, which means that each MTRR can only > cover 2GB of memory. With a memory size of, say, 256GB, and ten variable > MTRRs (such as some recent Intel CPUs have), it is not possible to set up > the MTRRs to cover all of memory. Linux drivers no longer use MTRR so why is the cleanup needed, ie, what would happen if the cleanup is just skipped in your case ? Luis