From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbbICJ1J (ORCPT ); Thu, 3 Sep 2015 05:27:09 -0400 Received: from 2.236.17.93.rev.sfr.net ([93.17.236.2]:27524 "EHLO mailhub1.si.c-s.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752813AbbICJ1H (ORCPT ); Thu, 3 Sep 2015 05:27:07 -0400 From: Christophe Leroy Subject: [PATCH] powerpc/book3s32: Only select PPC_HAVE_PMU on e600 To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , scottwood@freescale.com Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Joakim Tjernlund Message-Id: <20150903092704.2F4881A241D@localhost.localdomain> Date: Thu, 3 Sep 2015 11:27:03 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On PPC832x, perf record/report reports martian addresses 2.62% perf_reseau4 libpthread-2.18.so [.] __libc_send 2.56% perf_reseau4 [kernel.kallsyms] [k] __ip_make_skb 1.62% perf_reseau4 [kernel.kallsyms] [k] __ip_append_data.isra.39 1.55% perf_reseau4 [kernel.kallsyms] [k] ip_finish_output 1.33% perf_reseau4 [unknown] [k] 0x7ffffd94 1.33% perf_reseau4 [unknown] [k] 0x7ffffd95 1.28% perf_reseau4 [unknown] [k] 0x7ffffd97 1.26% perf_reseau4 [unknown] [k] 0x7ffffda3 1.24% perf_reseau4 [unknown] [k] 0x7ffffd98 1.22% perf_reseau4 [unknown] [k] 0x7ffffd92 1.22% perf_reseau4 [unknown] [k] 0x7ffffd9b [.....] This is due to function perf_instruction_pointer() reading SPR SIAR which doesn't exist on e300 core. The perf_instruction_pointer() is redefined in arch/powerpc/perf/core-book3s.c when CONFIG_PPC_PERF_CTRS is selected. This patch moves the selection of CONFIG_PPC_HAVE_PMU in 86xx section so that CONFIG_PPC_PERF_CTRS won't be selected for other 6xx powerpc Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/86xx/Kconfig | 1 + arch/powerpc/platforms/Kconfig.cputype | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/86xx/Kconfig b/arch/powerpc/platforms/86xx/Kconfig index 1afd1e4..bb24d2a 100644 --- a/arch/powerpc/platforms/86xx/Kconfig +++ b/arch/powerpc/platforms/86xx/Kconfig @@ -5,6 +5,7 @@ menuconfig PPC_86xx select FSL_SOC select ALTIVEC select ARCH_WANT_OPTIONAL_GPIOLIB + select PPC_HAVE_PMU_SUPPORT help The Freescale E600 SoCs have 74xx cores. diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index d642cf9..aa63b12 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -143,7 +143,6 @@ config PPC_BOOK3E config 6xx def_bool y depends on PPC32 && PPC_BOOK3S - select PPC_HAVE_PMU_SUPPORT config TUNE_CELL bool "Optimize for Cell Broadband Engine" -- 2.1.0