From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755018AbbICMHK (ORCPT ); Thu, 3 Sep 2015 08:07:10 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49780 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754003AbbICMHI (ORCPT ); Thu, 3 Sep 2015 08:07:08 -0400 Date: Thu, 3 Sep 2015 12:43:16 +0100 From: Mark Brown To: Songjun Wu Cc: nicolas.ferre@atmel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Message-ID: <20150903114316.GV12027@sirena.org.uk> References: <1441086101-15303-1-git-send-email-songjun.wu@atmel.com> <1441086101-15303-3-git-send-email-songjun.wu@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B52KEoKdbCpY/p3k" Content-Disposition: inline In-Reply-To: <1441086101-15303-3-git-send-email-songjun.wu@atmel.com> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 87.112.220.204 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --B52KEoKdbCpY/p3k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 01, 2015 at 01:41:41PM +0800, Songjun Wu wrote: > +classd: classd@fc048000 { > + compatible = "atmel,sama5d2-classd"; > + reg = <0xfc048000 0x100>; > + interrupts = <59 IRQ_TYPE_LEVEL_HIGH 7>; > + dmas = <&dma0 > + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) > + | AT91_XDMAC_DT_PERID(47))>; > + dma-names = "tx"; > + clocks = <&classd_clk>, <&classd_gclk>, <&audio_pll_pmc>; > + clock-names = "pclk", "gclk", "aclk"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_classd_default>; > + atmel,pwm-type = "diff"; > + atmel,non-overlap-time = <10>; > +}; > +Example: > +sound { > + compatible = "atmel,asoc-classd"; > + > + atmel,model = "classd @ SAMA5D2-Xplained"; > + atmel,audio-platform = <&classd>; > + atmel,audio-cpu-dai-name = "fc048000.classd"; > + atmel,audio-codec = <&classd>; > +}; Why is this a separate DT node? It seems that this IP is entirely self contained so I'm not clear why we need a separate node for the card, the card is usually a separate node because it ties together multiple different devices in the system but that's not the case here. --B52KEoKdbCpY/p3k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV6DJTAAoJECTWi3JdVIfQr/UH/0v02BuUxvvl8B3FsLgfC030 36b+leJfTzV4x+omYNXF1kRVNOQ0imERJ76KlDk6MKVfIk6XftO2LYcJpsJBqIrM QMyy0fiDk2GlQAA2aU3RkJ5HuOp4WJy2cavdk2ivkYleTSrxyws+SWDwa3zU/+xh ejgMlq37Vs3XH+MgKsiXeZXbXyvtKVtSZxqZwIgXpJx/m9QpXaAWTII87p0yIGcG y9CBpfgPKab5WFqzpD8cPzNy5ziAtXJD7OOUbk/iTcfU1EuFZynEWTkahQlO7ldr 0iFoh9Umb9UDQjMJF9S1jb2dPqaEBO84QFpaAJg2JIdyp1V4DyohlmqxCKZyZi4= =wNKq -----END PGP SIGNATURE----- --B52KEoKdbCpY/p3k--