From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754719AbbICMy7 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Sep 2015 08:54:59 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49865 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751225AbbICMy5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Sep 2015 08:54:57 -0400
Date: Thu, 3 Sep 2015 13:54:29 +0100
From: Mark Brown <broonie@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Vinod Koul <vinod.koul@intel.com>, Heiko Stuebner <heiko@sntech.de>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Doug Anderson <dianders@chromium.org>,
        Olof Johansson <olofj@google.com>, Sonny Rao <sonnyrao@chromium.org>,
        Addy Ke <addy.ke@rock-chips.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
        linux-spi@vger.kernel.org, Olof Johansson <olof@lixom.net>
Message-ID: <20150903125429.GA12027@sirena.org.uk>
References: <1441101381-1329-1-git-send-email-shawn.lin@rock-chips.com>
 <1441101524-1700-1-git-send-email-shawn.lin@rock-chips.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="5EhqeiticJwWsSCK"
Content-Disposition: inline
In-Reply-To: <1441101524-1700-1-git-send-email-shawn.lin@rock-chips.com>
X-Cookie: You are fairminded, just and loving.
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 87.112.220.204
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--5EhqeiticJwWsSCK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 01, 2015 at 05:58:44PM +0800, Shawn Lin wrote:

> Generic dma controller on Rockchips' platform cannot support
> DMAFLUSHP instruction which make dma to flush the req of non-aligned
> or non-multiple of what we need. That will cause an unrecoverable
> dma bus error. The saftest way is to set dma max burst to 1.

If this is a quirk of the DMA controller why is it being fixed with a
property specific to the SPI controller?  Can't the DMA controller just
override the burst size?

> +#define ROCKCHIP_SPI_BORKEN_BURST_LEN (1<<0) /* broken burst len*/

This is misspelt.

--5EhqeiticJwWsSCK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJV6EMFAAoJECTWi3JdVIfQ12EH/3J2qry3k16pYz7vDs0aG4y+
zC9BSz7ESW5CXlymQT4CP4cPG+6qEgp0/stwWCHq5ew3q5NkC+NFUleIN/4njiau
uNfyRwnUC7ovudKV4dNSSYTGazrghmM8+0CLg8GME7k4Dsk29N6F83CgGzqGJsak
hQRBtT8ssEbUrIySiu53qUZZ9ddDU/wWrRS48FOfcjd8SkfOhHHf5ZoZ2lJ9ry9q
U1d+HHUqGccmUNWzCIFbm646soEUkxeojQchNngQ3TTRdY7oCoO9lPA/NNKcwrCX
sU7vJMG/r3qkp5WwLsjAy9IshTPl3Jhwh+aOILUznPditIEwcWeTYAo79sSyRa4=
=MdEO
-----END PGP SIGNATURE-----

--5EhqeiticJwWsSCK--