From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757481AbbICRCm (ORCPT ); Thu, 3 Sep 2015 13:02:42 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:18876 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757423AbbICRCi (ORCPT ); Thu, 3 Sep 2015 13:02:38 -0400 Date: Thu, 3 Sep 2015 10:02:33 -0700 From: Bjorn Andersson To: Stephen Boyd CC: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 5/8] soc: qcom: smd: Remove use of VLAIS Message-ID: <20150903170233.GR13472@usrtlx11787.corpusers.net> References: <1441234011-4259-1-git-send-email-sboyd@codeaurora.org> <1441234011-4259-6-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1441234011-4259-6-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 02 Sep 15:46 PDT 2015, Stephen Boyd wrote: > Usage of VLAIS prevents clang from compiling this file, and it > also opens us to the possibility of allocating a large structure > on the stack to the point that we blow past the limit of the > kernel stack. Remove the VLAIS and allocate a structure on the > heap with kmalloc so that we're safer and more clang friendly. > Reviewed-by: Bjorn Andersson