From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756835AbbICTER (ORCPT ); Thu, 3 Sep 2015 15:04:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752647AbbICTEQ (ORCPT ); Thu, 3 Sep 2015 15:04:16 -0400 Date: Thu, 3 Sep 2015 21:04:11 +0200 From: Jiri Olsa To: Adrian Hunter Cc: Arnaldo Carvalho de Melo , kan.liang@intel.com, mingo@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [tip:perf/urgent] perf evlist: Open event on evsel cpus and threads Message-ID: <20150903190411.GA24774@krava.redhat.com> References: <1440138194-17001-1-git-send-email-kan.liang@intel.com> <55E84C60.4010309@intel.com> <20150903152713.GA2537@redhat.com> <55E8740F.1010107@intel.com> <20150903164109.GB2537@redhat.com> <20150903181939.GA20908@krava.redhat.com> <55E89398.7040802@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E89398.7040802@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2015 at 09:38:16PM +0300, Adrian Hunter wrote: SNIP > > > >perf_evlist__propagate_maps is called from perf_evlist__create_maps, > >so if evsel is added later it will not be affected, perhaps we need > >something like below > > Yes but it would be nice to have a single function to do it that knows > the rules for when the evsel->cpus should be retained. Say: > int __perf_evlist__propagate_maps(struct perf_evlist *evlist, struct perf_evsel *evsel) > then call it from perf_evlist__propagate_maps(), perf_evlist__add() and > perf_evlist__splice_list_tail(). Probably need to add a member to perf_evlist > to know when the evlist->cpus should replace the evsel->cpus ook, jirka