From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757765AbbIDIqn (ORCPT ); Fri, 4 Sep 2015 04:46:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41884 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753606AbbIDIql (ORCPT ); Fri, 4 Sep 2015 04:46:41 -0400 Date: Fri, 4 Sep 2015 10:46:36 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/9] perf, tools, stat: Abstract stat metrics printing Message-ID: <20150904084636.GB12338@krava.redhat.com> References: <1441236954-24886-1-git-send-email-andi@firstfloor.org> <1441236954-24886-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441236954-24886-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 04:35:47PM -0700, Andi Kleen wrote: SNIP > > @@ -752,15 +796,7 @@ static void print_counter(struct perf_evsel *counter, char *prefix) > } > > uval = val * counter->scale; > - > - if (nsec_counter(counter)) > - nsec_printout(cpu, 0, counter, uval); > - else > - abs_printout(cpu, 0, counter, uval); > - > - if (!csv_output) > - print_noise(counter, 1.0); > - print_running(run, ena); why removing print_running/print_noise now? jirka