From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758474AbbIDJAi (ORCPT ); Fri, 4 Sep 2015 05:00:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48383 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbbIDJAg (ORCPT ); Fri, 4 Sep 2015 05:00:36 -0400 Date: Fri, 4 Sep 2015 11:00:30 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/9] perf, tools, stat: Abstract stat metrics printing Message-ID: <20150904090030.GE12338@krava.redhat.com> References: <1441236954-24886-1-git-send-email-andi@firstfloor.org> <1441236954-24886-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441236954-24886-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 04:35:47PM -0700, Andi Kleen wrote: SNIP > diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h > index 62448c8..bb07e46 100644 > --- a/tools/perf/util/stat.h > +++ b/tools/perf/util/stat.h > @@ -67,11 +67,21 @@ void perf_stat_evsel_id_init(struct perf_evsel *evsel); > > extern struct stats walltime_nsecs_stats; > > +typedef void (*print_metric_t)(void *ctx, const char *color, const char *unit, > + const char *fmt, double val); > + > void perf_stat__reset_shadow_stats(void); > void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 *count, > int cpu); > -void perf_stat__print_shadow_stats(FILE *out, struct perf_evsel *evsel, > - double avg, int cpu, enum aggr_mode aggr); > +struct perf_stat_output_ctx { > + void *ctx; > + print_metric_t print_metric; > + void (*new_line)(void *ctx); please add typedef for new_line as well jirka