mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Raphaël Beamonte" <raphael.beamonte@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH 11/15] tools lib api: Add mount support for fs
Date: Fri, 4 Sep 2015 10:20:45 -0400	[thread overview]
Message-ID: <20150904102045.0c8ca5c9@gandalf.local.home> (raw)
In-Reply-To: <CAE_Gge38k1KaHJFUk7XmR6CgV7URLbBoV8qyjYmiHRSauPJynA@mail.gmail.com>

On Fri, 4 Sep 2015 10:14:28 -0400
Raphaël Beamonte <raphael.beamonte@gmail.com> wrote:

> 2015-09-02 3:56 GMT-04:00 Jiri Olsa <jolsa@kernel.org>:
> > Adding name__mount (where name is in sysfs,procfs,debugfs,tracefs)
> > interface that tries to mount the filesystem in case no mount is found.
> >
> > Link: http://lkml.kernel.org/n/tip-ja49vwfiq2qqkmoxx9yk26lm@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/lib/api/fs/fs.c | 44 +++++++++++++++++++++++++++++++++++++++-----
> >  tools/lib/api/fs/fs.h | 15 +++++++++++----
> >  2 files changed, 50 insertions(+), 9 deletions(-)
> 
> Why automatic mounting the **fs filesystems?
> Isn't it better to let the user decide when and where to mount it if
> s/he forgot to do it before? Forcing a mount is also potentially
> forcing to umount then mount when mounting has been forgotten before.
> 

tracefs and debugfs have known locations to be mounted at. That's why
the kernel supplies it (/sys/kernel/debug and /sys/kernel/trace). Why
should we bother the user with this? trace-cmd does the same thing. It
automatically mounts the filesystems if they are not mounted.

Would you rather have the tool fail and say "please mount the
trace or debugfs file system"? Even if it asked before doing so, that
would become rather annoying.

Running perf and trace-cmd should just work, and not expect the user to
do more work than can be easily done by the tool.

-- Steve

  reply	other threads:[~2015-09-04 14:20 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02  7:56 [PATCH 00/15] perf tools: Cleanup filesystem api Jiri Olsa
2015-09-02  7:56 ` [PATCH 01/15] perf tools: Fix parse_events_add_pmu caller Jiri Olsa
2015-09-02 13:00   ` Arnaldo Carvalho de Melo
2015-09-02 13:34     ` Jiri Olsa
2015-09-05 14:00   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 02/15] perf tools: Remove mountpoint arg from perf_debugfs_mount Jiri Olsa
2015-09-08 14:32   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 03/15] perf tools: Move tracing_path stuff under same namespace Jiri Olsa
2015-09-08 14:33   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 04/15] perf tools: Move tracing_path interface into api/fs/tracing_path.c Jiri Olsa
2015-09-04 11:35   ` Matt Fleming
2015-09-04 13:28     ` Raphaël Beamonte
2015-09-08 14:33   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 05/15] tools lib api: Move debugfs__strerror_open into tracing_path.c object Jiri Olsa
2015-09-02 13:12   ` Arnaldo Carvalho de Melo
2015-09-04 11:36   ` Matt Fleming
2015-09-04 13:41   ` Raphaël Beamonte
2015-09-04 13:48     ` Jiri Olsa
2015-09-04 13:51       ` Raphaël Beamonte
2015-09-08 14:33   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 06/15] tools lib api: Make tracing_path_strerror_open message generic Jiri Olsa
2015-09-02 13:18   ` Arnaldo Carvalho de Melo
2015-09-02 13:44     ` Jiri Olsa
2015-09-02 14:16       ` Arnaldo Carvalho de Melo
2015-09-15  6:59   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 07/15] tools lib api: Add STR and PATH_MAX macros to fs object Jiri Olsa
2015-09-08 14:34   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 08/15] tools lib api: Move SYSFS_MAGIC PROC_SUPER_MAGIC into fs.c Jiri Olsa
2015-09-08 14:34   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 09/15] tools lib api: Add debugfs into fs.c object Jiri Olsa
2015-09-08 14:34   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 10/15] tools lib api: Add tracefs " Jiri Olsa
2015-09-08 14:35   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 11/15] tools lib api: Add mount support for fs Jiri Olsa
2015-09-04 14:14   ` Raphaël Beamonte
2015-09-04 14:20     ` Steven Rostedt [this message]
2015-09-04 14:26     ` Jiri Olsa
2015-09-04 14:57       ` Steven Rostedt
2015-09-04 15:00         ` Steven Rostedt
2015-09-04 15:12           ` Raphaël Beamonte
2015-09-08 14:35   ` [tip:perf/core] tools lib api fs: Add FSTYPE__mount() method tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 12/15] tools lib api: Add configured support for fs Jiri Olsa
2015-09-02 13:39   ` Arnaldo Carvalho de Melo
2015-09-02 13:41     ` Arnaldo Carvalho de Melo
2015-09-02 13:46     ` Jiri Olsa
2015-09-02 14:17       ` Arnaldo Carvalho de Melo
2015-09-02 16:52         ` Arnaldo Carvalho de Melo
2015-09-04  7:08           ` Jiri Olsa
2015-09-04 16:42             ` Arnaldo Carvalho de Melo
2015-09-04 17:45               ` Jiri Olsa
2015-09-08 14:35   ` [tip:perf/core] tools lib api fs: Add FSTYPE__configured() method tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 13/15] tools lib api: Replace debugfs/tracefs objects interface with fs.c Jiri Olsa
2015-09-15  6:59   ` [tip:perf/core] tools lib api fs: Replace debugfs/ tracefs " tip-bot for Jiri Olsa
2015-09-02  7:56 ` [PATCH 14/15] tools lib api: Remove debugfs, tracefs and findfs objects Jiri Olsa
2015-09-15  6:59   ` [tip:perf/core] tools lib api fs: " tip-bot for Jiri Olsa
2015-09-22  0:20     ` Vinson Lee
2015-09-22 13:53       ` Arnaldo Carvalho de Melo
2015-09-22 21:29         ` Vinson Lee
2015-09-23  8:23       ` Matt Fleming
2015-09-23  8:39         ` Jiri Olsa
2015-09-23 10:08           ` Matt Fleming
2015-09-24 15:05             ` Michael Petlan
2015-10-07 20:10               ` Matt Fleming
2015-10-13 19:18                 ` Arnaldo Carvalho de Melo
2015-09-23 13:44           ` Arnaldo Carvalho de Melo
2015-09-23 13:50             ` Jiri Olsa
2015-09-23 13:54               ` Arnaldo Carvalho de Melo
2015-09-24 12:15             ` Matt Fleming
2015-09-24 14:29               ` Arnaldo Carvalho de Melo
2015-09-02  7:56 ` [PATCH 15/15] perf tools: Switch to tracing_path interface on appropriate places Jiri Olsa
2015-09-15  7:00   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-09-02  8:01 ` [PATCH 00/15] perf tools: Cleanup filesystem api Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150904102045.0c8ca5c9@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=raphael.beamonte@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®