From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757660AbbIDLzv (ORCPT <rfc822;w@1wt.eu>);
	Fri, 4 Sep 2015 07:55:51 -0400
Received: from mail-pa0-f43.google.com ([209.85.220.43]:32898 "EHLO
	mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755281AbbIDLzu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 4 Sep 2015 07:55:50 -0400
Date: Fri, 4 Sep 2015 20:52:36 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: =?utf-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= 
	<masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Wang Nan <wangnan0@huawei.com>,
        "pi3orama@163.com" <pi3orama@163.com>,
        sysp-manager <cti.systems-productivity-manager.ts@hitachi.com>
Subject: Re: [PATCH 2/5] perf probe: Attach trace_probe_event with
 perf_probe_event
Message-ID: <20150904115236.GA11132@danjae.kornet>
References: <1441352378-17988-1-git-send-email-namhyung@kernel.org>
 <1441352378-17988-2-git-send-email-namhyung@kernel.org>
 <50399556C9727B4D88A595C8584AAB375250D1DC@GSjpTKYDCembx32.service.hitachi.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <50399556C9727B4D88A595C8584AAB375250D1DC@GSjpTKYDCembx32.service.hitachi.net>
User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 04, 2015 at 11:36:56AM +0000, 平松雅巳 / HIRAMATU，MASAMI wrote:
> > From: Namhyung Kim [mailto:namhyung@kernel.org]

Oh, this patch is came from Wang Nan.  I missed to update the author,
will change in v2.


> > 
> > This patch drops struct __event_package structure.  Instead, it adds
> > trace_probe_event into 'struct perf_probe_event'.
> > 
> > trace_probe_event information gives further patches a chance to access
> > actual probe points and actual arguments.  Using them, perf probe can
> > get whole list of added probes and print them at once.
> > 
> > Other users like upcoming bpf_loader will be able to attach one bpf
> > program to different probing points of an inline functions (which has
> > multiple probing points) and glob functions.  Moreover, by reading
> > arguments information, bpf code for reading those arguments can be
> > generated.
> 
> Looks good to me.
> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks
Namhyung