From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758229AbbIDL4p (ORCPT ); Fri, 4 Sep 2015 07:56:45 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:34402 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757467AbbIDL4o (ORCPT ); Fri, 4 Sep 2015 07:56:44 -0400 Date: Fri, 4 Sep 2015 20:53:32 +0900 From: Namhyung Kim To: =?utf-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Wang Nan , "pi3orama@163.com" , sysp-manager Subject: Re: [PATCH 5/5] perf probe: Print deleted events in cmd_probe() Message-ID: <20150904115332.GB11132@danjae.kornet> References: <1441352378-17988-1-git-send-email-namhyung@kernel.org> <1441352378-17988-5-git-send-email-namhyung@kernel.org> <50399556C9727B4D88A595C8584AAB375250D256@GSjpTKYDCembx32.service.hitachi.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50399556C9727B4D88A595C8584AAB375250D256@GSjpTKYDCembx32.service.hitachi.net> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 11:46:45AM +0000, 平松雅巳 / HIRAMATU,MASAMI wrote: > > From: Namhyung Kim [mailto:namhyung@kernel.org] > > > > Showing actual trace event when deleteing perf events is only needed in > > perf probe command. But the add functionality itself can be used by > > other places. So move the printing code into the cmd_probe(). > > > > The output is not changed. > > > > OK, I just have a comment below. > > > diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h > > index 610f743671e1..d491cf69f91b 100644 > > --- a/tools/perf/util/probe-event.h > > +++ b/tools/perf/util/probe-event.h > > @@ -144,6 +144,11 @@ extern int convert_perf_probe_events(struct perf_probe_event *pevs, int npevs); > > extern int apply_perf_probe_events(struct perf_probe_event *pevs, int npevs); > > extern void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs); > > extern int del_perf_probe_events(struct strfilter *filter); > > + > > +extern int probe_file__get_events(int fd, struct strfilter *filter, > > + struct strlist *plist); > > +extern int probe_file__del_strlist(int fd, struct strlist *namelist); > > These should be moved into probe-file.h. Right, will change! Thanks, Namhyung > > > + > > extern int show_perf_probe_event(const char *group, const char *event, > > struct perf_probe_event *pev, > > const char *module, bool use_stdout); > > Thanks! >