From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753999AbbIGGtv (ORCPT ); Mon, 7 Sep 2015 02:49:51 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:42073 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbbIGGtt (ORCPT ); Mon, 7 Sep 2015 02:49:49 -0400 Date: Sun, 06 Sep 2015 23:49:48 -0700 (PDT) Message-Id: <20150906.234948.490398330420454086.davem@davemloft.net> To: sergei.shtylyov@cogentembedded.com Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add() From: David Miller In-Reply-To: <3613326.r1qXWqo08b@wasted.cogentembedded.com> References: <3613326.r1qXWqo08b@wasted.cogentembedded.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 06 Sep 2015 23:49:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergei Shtylyov Date: Thu, 03 Sep 2015 23:22:16 +0300 > I've noticed that fixed_phy_register() ignores its 'irq' parameter instead of > passing it to fixed_phy_add(). Luckily, fixed_phy_register() seems to always > be called with PHY_POLL for 'irq'... :-) > > Fixes: a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()") > Signed-off-by: Sergei Shtylyov Applied, thanks.