From: Mark Brown <broonie@kernel.org>
To: Alexey Klimov <alexey.klimov@linaro.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-spi@vger.kernel.org, Alexey Klimov <klimov.linux@gmail.com>,
djkurtz@chromium.org, linux-kernel@vger.kernel.org,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree"
Date: Sun, 6 Sep 2015 01:06:40 +0100 [thread overview]
Message-ID: <20150906000640.GR5313@sirena.org.uk> (raw)
In-Reply-To: <CAP_9M6973VAtM6WkP7gkzDMnJbRxmmmiCCuSxMU-_aQm4YQZbg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Sun, Sep 06, 2015 at 01:47:21AM +0300, Alexey Klimov wrote:
> During review of new SPI drivers I tried to understand connection
> between comment "calling spi_master_put() and kfree() to prevent a
> memory leak" for spi_alloc_master() in spi.c and why no driver calls
> kfree() on error path. Looks like Uwe added this comment and later I
> found patch from Guenter that reverted this comment but spi-imx.c was
> not fixed for that time. Later in 2013 spi-imx was fixed. Is it
> correct time right now to fix comment?
I'm sorry but I'm not clear what you're talking about here as there's
missing context... where is this comment you're talking about?
In general please don't send cover letters for single patches, either
add the content to the commit message or put it after the --- if it's
administrative stuff (like SubmittingPatches says).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-06 0:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 22:47 Alexey Klimov
2015-09-06 0:06 ` Mark Brown [this message]
2015-09-06 0:22 ` Alexey Klimov
2015-09-07 10:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906000640.GR5313@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexey.klimov@linaro.org \
--cc=djkurtz@chromium.org \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®