From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753595AbbIGFxK (ORCPT ); Mon, 7 Sep 2015 01:53:10 -0400 Received: from lgeamrelo02.lge.com ([156.147.1.126]:52290 "EHLO lgeamrelo02.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbbIGFxI (ORCPT ); Mon, 7 Sep 2015 01:53:08 -0400 X-Original-SENDERIP: 10.177.222.138 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Mon, 7 Sep 2015 14:53:06 +0900 From: Joonsoo Kim To: Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman , David Rientjes Subject: Re: [PATCH 3/3] mm, compaction: disginguish contended status in tracepoint Message-ID: <20150907055306.GD21207@js1304-P5Q-DELUXE> References: <1440689044-2922-1-git-send-email-vbabka@suse.cz> <1440689044-2922-3-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440689044-2922-3-git-send-email-vbabka@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 27, 2015 at 05:24:04PM +0200, Vlastimil Babka wrote: > Compaction returns prematurely with COMPACT_PARTIAL when contended or has fatal > signal pending. This is ok for the callers, but might be misleading in the > traces, as the usual reason to return COMPACT_PARTIAL is that we think the > allocation should succeed. This patch distinguishes the premature ending > condition. Further distinguishing the exact reason seems unnecessary for now. isolate_migratepages() could return ISOLATE_ABORT and skip to call compact_finished(). trace_mm_compaction_end() will print COMPACT_PARTIAL in this case and we cannot distinguish premature ending condition. Is it okay? Thanks.