From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754038AbbIGIwn (ORCPT ); Mon, 7 Sep 2015 04:52:43 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34631 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925AbbIGIwl (ORCPT ); Mon, 7 Sep 2015 04:52:41 -0400 Date: Mon, 7 Sep 2015 14:19:11 +0530 From: maitysanchayan@gmail.com To: Shawn Guo Cc: stefan@agner.ch, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Message-ID: <20150907084911.GA6877@Sanchayan-Arch.toradex.int> References: <20150906043232.GD30746@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150906043232.GD30746@tiger> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 15-09-06 12:32:32, Shawn Guo wrote: > On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote: > > Add iio_hwmon node to expose the temperature channel on Vybrid > > as hardware monitor device using the iio_hwmon driver. > > > > Signed-off-by: Sanchayan Maity > > --- > > arch/arm/boot/dts/vfxxx.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > > index 39173bb..0993d66 100644 > > --- a/arch/arm/boot/dts/vfxxx.dtsi > > +++ b/arch/arm/boot/dts/vfxxx.dtsi > > @@ -597,5 +597,10 @@ > > status = "disabled"; > > }; > > }; > > + > > + iio_hwmon { > > Hyphen rather than underscore should be used in node name. As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi. http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85 http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570 http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246 So should this be changed? Thanks. - Sanchayan. > > Shawn > > > + compatible = "iio-hwmon"; > > + io-channels = <&adc0 16>; > > + }; > > }; > > }; > > -- > > 2.5.0 > >