From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751592AbbIGLgh (ORCPT ); Mon, 7 Sep 2015 07:36:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43705 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbbIGLgf (ORCPT ); Mon, 7 Sep 2015 07:36:35 -0400 Date: Mon, 7 Sep 2015 13:36:30 +0200 From: Jiri Olsa To: kan.liang@intel.com Cc: acme@kernel.org, jolsa@kernel.org, a.p.zijlstra@chello.nl, luto@kernel.org, mingo@redhat.com, eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com, adrian.hunter@intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V8 0/7] Freq/CPU%/CORE_BUSY% support Message-ID: <20150907113630.GC5806@krava.brq.redhat.com> References: <1441283463-51050-1-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441283463-51050-1-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2015 at 08:30:56AM -0400, kan.liang@intel.com wrote: > From: Kan Liang > > This patch set supports per-sample freq/CPU%/CORE_BUSY% print in perf > report -D and --stdio. > For printing these information, the perf.data file must have been obtained > by group read and using special events cycles, ref-cycles, msr/tsc/, > msr/aperf/ or msr/mperf/. > > - Freq (MHz): The frequency during the sample interval. Needs cycles > ref-cycles event. > - CPU%: CPU utilization during the sample interval. Needs ref-cycles and > msr/tsc/ events. > - CORE_BUSY%: actual percent performance (APERF/MPERF%) during the > sample interval. Needs msr/aperf/ and msr/mperf/ events. > > Here is an example: other than my latest 2 comments, I'm ok with the patchset jirka