From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbbIGLnS (ORCPT ); Mon, 7 Sep 2015 07:43:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35823 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbbIGLnR (ORCPT ); Mon, 7 Sep 2015 07:43:17 -0400 Date: Mon, 7 Sep 2015 13:43:14 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Message-ID: <20150907114314.GD5806@krava.brq.redhat.com> References: <1441406717-1717-1-git-send-email-andi@firstfloor.org> <1441406717-1717-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441406717-1717-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 03:45:13PM -0700, Andi Kleen wrote: SNIP > @@ -695,11 +743,7 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix) > } > > uval = avg * counter->scale; > - > - if (nsec_counter(counter)) > - nsec_printout(-1, 0, counter, uval); > - else > - abs_printout(-1, 0, counter, uval); > + printout(-1, 0, counter, uval); > > print_noise(counter, avg); > > @@ -752,15 +796,9 @@ static void print_counter(struct perf_evsel *counter, char *prefix) > } > > uval = val * counter->scale; > - > - if (nsec_counter(counter)) > - nsec_printout(cpu, 0, counter, uval); > - else > - abs_printout(cpu, 0, counter, uval); > - > + printout(cpu, 0, counter, uval); > if (!csv_output) > print_noise(counter, 1.0); > - print_running(run, ena); why is this one removed? jirka