From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbbIGMqd (ORCPT ); Mon, 7 Sep 2015 08:46:33 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33278 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbbIGMqb (ORCPT ); Mon, 7 Sep 2015 08:46:31 -0400 Date: Mon, 7 Sep 2015 18:16:21 +0530 From: Sudip Mukherjee To: Andrey Shvetsov Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 3/5] staging: most: remove driver owner Message-ID: <20150907124621.GA16559@sudip-pc> References: <1441363926-5025-1-git-send-email-sudipm.mukherjee@gmail.com> <1441363926-5025-3-git-send-email-sudipm.mukherjee@gmail.com> <20150907121337.GA6992@KAR-DK-M21181> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150907121337.GA6992@KAR-DK-M21181> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote: > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > > The platform driver core will set the owner value, we do not need to do > > it in the module. > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c > > index 5b0a588..4481a0b 100644 > > --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c > > +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c > > @@ -923,7 +923,6 @@ static struct platform_driver dim2_driver = { > > .id_table = dim2_id, > > .driver = { > > .name = "hdm_dim2", > > - .owner = THIS_MODULE, > I cannot accept this. > > This change is not significant for current kernel, but we still have customers > using kernels <= 3.10, where auto assignment of .owner does not exist. But this patch is for 4.4-rc1, and it is not marked for stable. Then how is it going to affect your customers who are still using <=3.10? regards sudip