From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbbIGQ0L (ORCPT ); Mon, 7 Sep 2015 12:26:11 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54945 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083AbbIGQ0E (ORCPT ); Mon, 7 Sep 2015 12:26:04 -0400 Date: Mon, 7 Sep 2015 17:25:48 +0100 From: Mark Brown To: "Wu, Songjun" Cc: nicolas.ferre@atmel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Message-ID: <20150907162548.GW5313@sirena.org.uk> References: <1441086101-15303-1-git-send-email-songjun.wu@atmel.com> <1441086101-15303-3-git-send-email-songjun.wu@atmel.com> <20150903114316.GV12027@sirena.org.uk> <55EC0AFE.3080809@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dPKyTZoWbiJp7FfC" Content-Disposition: inline In-Reply-To: <55EC0AFE.3080809@atmel.com> X-Cookie: Short people get rained on last. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dPKyTZoWbiJp7FfC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote: > On 9/3/2015 19:43, Mark Brown wrote: > >Why is this a separate DT node? It seems that this IP is entirely self > >contained so I'm not clear why we need a separate node for the card, the > >card is usually a separate node because it ties together multiple > >different devices in the system but that's not the case here. > The classD can finish the audio function without other devices. > But I want to reuse the code in ASoC, leave many things(like creating PCM, > DMA operations) to ASoC, then the driver can only focus on how to configure > classD. > The classD IP is divided to tree parts logically, platform, CPU dai, > and codec, and these parts are registered to ASoC. > This separate DT node is needed in ASoC, ties these tree parts in ClassD. Sure, there's no problem at all having that structure in software but it should be possible to do this without having to represent this structure in DT. It should be possible to register the card at the same time as the rest of the components rather than needing the separate device in the DT. --dPKyTZoWbiJp7FfC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV7bqLAAoJECTWi3JdVIfQVBoH/Rw8yw1K58ndD0wfnzLwsdKs NGMcI/cAKZCtSEVC829ik7khw2Qf/r6arJffVRFIE0q8EF1kVvPrQa5QuRP5nyV5 4wGLj6T5EPUJ1zre03AHr24klKaaAPp0c3EswSaUEebXNP01KyKWHcHcTSdpT6z4 8CRWYdNvC9MeQKmYQxODNYGomkVkkULn240sltFxbBqkb2MCsAEwGMnyirXqlmBU 6edC6C7+4+mxm+jb4dHymbPA5wUGq+T58v5ShEO4fU3NlHOYKKLtFPYjFw1PJlyC pxiRNC86DrSaRm7j/hX8Ewk6KUnn4FIqnoPdr6xTFQbG/Eoyy0Y+BfbgDD+hky4= =fDa0 -----END PGP SIGNATURE----- --dPKyTZoWbiJp7FfC--