From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517AbbIGQtW (ORCPT ); Mon, 7 Sep 2015 12:49:22 -0400 Received: from mail-bl2on0061.outbound.protection.outlook.com ([65.55.169.61]:57403 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752491AbbIGQtU (ORCPT ); Mon, 7 Sep 2015 12:49:20 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@caviumnetworks.com; Date: Mon, 7 Sep 2015 18:48:44 +0200 From: Robert Richter To: Marc Zyngier CC: Ganapatrao Kulkarni , , , , , , , , Subject: Re: [PATCH v2] irqchip, gicv3-its, numa: Workaround for Cavium ThunderX erratum 23144 Message-ID: <20150907164844.GU1820@rric.localdomain> References: <1440497885-24584-1-git-send-email-gkulkarni@caviumnetworks.com> <55EDBEF9.4050007@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55EDBEF9.4050007@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.193.81] X-ClientProxiedBy: AM2PR02CA0020.eurprd02.prod.outlook.com (25.160.28.158) To CY1PR0701MB1613.namprd07.prod.outlook.com (25.163.20.150) X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1613;2:bQ7f94nUdAoYxYYY0UuJwkLitzddozKj+PWUbP5Sn4A0QAtK63rbv6S4DaN57M7STY7RevpFUzgdTI0Nba48AT53WM17WeqVF7NgbkzMOr6xJjnN0D0yotr3/Lx6k62XsnjJV/TDiJ0iZGSgUMG60MD2vLVuQSZWyCrtggrMOYo=;3:eDVqUqDQtXDAh7oKRFf3hpC3WmgMbRxv9jCbKvDd0v8j8L4A3SkaijK0VdyCqoPLOFXQT9+XP103IbYvmPUI0w8r2wZGhIe5VVb3vbWT+84lW8D8aqq2XDcOeHrdTi7dioKCh3N51kFHworV6SCSGw==;25:PpAxcoyYJG/nJdavqT1RX5BcbHIZolHSYCHeE91C5Yz9o4lYEN4hizHLGtDFiTIKa/e7204CmQAMaXxozF/j5blqaatqhIvhb+2tW37lzbgYUQwJ6zP/g2E/5b0NKzAX33LLAh3nyEjR99JGqwudryFy2CeOgCZuX41Ig3va/VCx1T2GdrFi9CNIO8jNQHlhvvSaFgIRLYIFv3PfJdz5sZY56pNvHi+i9nE1mwYsDOxKLYOcQnQ684jaOYk5yTXXFxIxpUzRJanuljrsiWyzgQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1613; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1613;20:ld3T9v0s2zRwKwA9CCg1Acj1RQ58fCUXcXhfhQc3xBnJFP3dP6zCuV8JYBAw0SLiWStpB1jjopmdf2hlrbO4jxheA+XC2cSg4U+AdP/qCCeQcPVXmPzVxr34IxQ95BO8KM2qyUBHfKurrQsqSrtR3bjXMv2SGF64juCzUFJgw8SQ6bQkWKGF5+fRJdM01NJeGi5GNaM4Q5CcLa533ilYYeBlRlTcqfpStQa56H+ItYX/BaoZ00LXeDrWVjg8el3apMQoopdzAc1aDL1s5nVI4ALs1kkVevGV18kuxMXjK+vSYCfudO2uaWJuDssd+nAds9O/+YCPUbaPjDt7baLNMhvRm6vEZtzElJQwyiZ6TevYvCFct5oReGCwvlkqiHMLVu0qQyHECGMtCy90R3hrGtebjecYbdywwN8w5jJWBQmZsWuXkv7CiELckY+3hAEVGd5Cyu+Me5whuZLFw2zlcVEpa5+cc7dwOJX52v3FB4a/vRdvdIHjgiyRVXsAaFJo1VS8g/0tTx5hvtaklz7whfxlkYXIljKGIO/252gipE0Np0VBKv1hCJBWmqYX9vjDp1CO80rYIkUqCacWtBeZvOTnZvaPhavnSjsm/T2FFzA=;4:h+0Z51G1yqYuOX3GtpoXC/4xfxGcdY2YQ3OKYDfgkpv/tgcQubZLm+0dwRVKc6EbEBMK2wzFU4VCerH9LxqPYKXtQKUIaypBT0oGZbCJzvd6lNy1d60UBNbpQdw7RSdB+VLSrwqX8v2Vh2lxX4qEAg4KMxaBeAesna1lM5xZd4g9Rl1tt1lcWlnFQm3/4+zVZ7GqzD43vBw7tJoLyXs+QLNdskbxQZ5su4wxWiqK4NwaB3S9k1tsXuhxT+lM2f08UxrHpgbjT6qVhNIOvehMxJIq+7OqSGia0rq9MXETe5WuoqYehGC4ypckdLOdFr+3cgAK7CWxHwbBA7Lu+K0dIA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:CY1PR0701MB1613;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0701MB1613; X-Forefront-PRVS: 069255B8B8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(199003)(189002)(24454002)(164054003)(479174004)(23726002)(105586002)(106356001)(68736005)(77096005)(19580395003)(575784001)(86362001)(87976001)(83506001)(62966003)(33656002)(19580405001)(77156002)(42186005)(64706001)(47776003)(101416001)(76176999)(5001960100002)(110136002)(46102003)(5001830100001)(189998001)(50986999)(5001860100001)(54356999)(50466002)(46406003)(97756001)(66066001)(5007970100001)(5004730100002)(2950100001)(92566002)(122386002)(40100003)(4001350100001)(4001540100001)(81156007)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0701MB1613;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0701MB1613;23:rWlQ+FN86iDB6bA6iTayyBV130isFuCq3nGqhtZ?= =?us-ascii?Q?zWDWRIk4OoUjn6w24/ElHmpvkfHpFPsbS0/UJAxM/2yY+2VYRCuvgC/CFuHz?= =?us-ascii?Q?BBrk4P1VlN/49YWjWFyuvkQVcKUxZMKVmdcZSKLFrOWK3rDYSHygK6e290ue?= =?us-ascii?Q?q/isqebNWjE7S1dW79PpThN9/ERQE4IO7yusJG3N/FK7yj7K6qdXDeITbSl5?= =?us-ascii?Q?z8YodiGGASls0//pBn6F6gtEudvgY/d2XlTmflqydO1cOtDkpfj/g/UA8yIu?= =?us-ascii?Q?m81GAsAw3cHHQXd93/jI6bGlmA0vWhzlez3L39j6nhW3XF8u75j9xuyl3FTN?= =?us-ascii?Q?/4Da7Ajsfa035VnDfUeXnWmAp7R8W7X6hcsQkUt+0OIONPXRUUBpJyY6KjjF?= =?us-ascii?Q?pVNkzUl9H8ieKI0U0+wL49jfftLYH4Lp/EZ6HX+rYd4HKnK/Tt+HpoTxPNgq?= =?us-ascii?Q?YEdjjntBclxQZoCGKo8aTJKL64a4fk4UUd12G69pI64qXrKfN/ojj+y6HtS7?= =?us-ascii?Q?5DoES/Tbjrb2Cn6+4QEggovxNy1WXDSEV5o+3N8Dx+a/89friWNrvAT+NeJn?= =?us-ascii?Q?blwcW922ASpdn6piQ/7KORHZEfVHV130PBbSeYp6bMRUcYjedDzz0T5z/r2V?= =?us-ascii?Q?8cApvaTj8CO0SrPlTiMRor8EuCehDHJTOhVndG6i1eeL6dheUmRrR2oExXac?= =?us-ascii?Q?pONhUaNlICGUVfXNKvOopmlKyqxqGv19sWgfuhk+TBJYJ9pXGNgPFahKxsB0?= =?us-ascii?Q?iXTFk8LJ/9RZeFOH+TSSKX5O2K2dRUWd0MTPsz0jvlrc2oIiDPaWKk2NsG6V?= =?us-ascii?Q?YUeiDMfN58m1Wc4DHHbRZlbQFyrwUFOYd2IDElo2kC0K+4Gc1SQc4y8qbbeq?= =?us-ascii?Q?/EwWiabNWg7ie0BlAP1gGBJ/vQaQEcmAtep8lycCLHWIu6ZLZ/1rO2mMzSSM?= =?us-ascii?Q?nMPZekZVglHA/TI1v5ZVrlVU8PBwWGiV+nIadk7+JzSy0Qn9q1DdPNgaxQ4S?= =?us-ascii?Q?1KeAbqjL8wT9xlFoG23ViN8bxDNSyH1rautnAqrnpHyj9PU9KBnmVVzDPRJj?= =?us-ascii?Q?CaQ40zfZfivPtd5PVhGCD+J3kWH4thC2DoA8mozjkGPGum0PwmLf6IzBD9i3?= =?us-ascii?Q?pkxCyTEv3ZEzlFiEq03BD52YFfwdcVnNjrdyDs05zZWJ+ZREMqjM4d/G6S3P?= =?us-ascii?Q?/NdzIjMxEDk7QD2rSRvOa+0rT9U+MEBSCLLa9KQ5mIc9SpSXdGVtbfVm4H0S?= =?us-ascii?Q?ciPP3UVyq4HhhOtsSkz6hbklrP5xLgOvJgpk1W4Rf?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0701MB1613;5:kFePbZycEy214yQ9S7TcD7fDNDJCxmv/iMsgPR/h5aM8ghuOQ5IY4AORT6dBS4jKSiOwDS4lMeUSh/Vk0VkryBjb8txlvHNmmqaByhfrX5IwRZXXMoO/iZ5GIk6QiacUI5JXYsbgAbhK/6BSospckg==;24:Q5Of0rmOKRTLo529CLeLrcJrY9INSPEUYHjJuB9EdRGponok/quXh9qj77jgtiXQqI7Txg0vpmyFaazc8bisj65HSCQJZ+SNgWqm9MFkecs=;20:cZYoRn5FTZYxyI8uxLzh1+/RPZf5ouYi5td9RvgqOaZu5Sx7l0BFvLyH/n7mxKJn+sD5x22DuRjFEGEyTmtllQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2015 16:49:14.8718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1613 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.09.15 17:44:41, Marc Zyngier wrote: > On 25/08/15 11:18, Ganapatrao Kulkarni wrote: > > The patch below adds a workaround for gicv3 in a numa environment. It > > is on top of Robert's recent gicv3 errata patch submission v4 and my > > arm64 numa patches v5. > > > > This implements a workaround for gicv3-its erratum 23144 on Cavium's > > ThunderX dual-socket platforms, where LPI cannot be routed to a > > redistributors present on a foreign node. > > > > v2: > > updatated as per Marc Zyngier's review comments. > > > > Signed-off-by: Ganapatrao Kulkarni > > Signed-off-by: Robert Richter > > --- > > drivers/irqchip/irq-gic-v3-its.c | 53 +++++++++++++++++++++++++++++++++------- > > 1 file changed, 44 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > > index 614a367..d3fe0a4 100644 > > --- a/drivers/irqchip/irq-gic-v3-its.c > > +++ b/drivers/irqchip/irq-gic-v3-its.c > > @@ -40,7 +40,8 @@ > > #include "irqchip.h" > > > > #define ITS_FLAGS_CMDQ_NEEDS_FLUSHING (1ULL << 0) > > -#define ITS_FLAGS_CAVIUM_THUNDERX (1ULL << 1) > > +#define ITS_WORKAROUND_CAVIUM_22375 (1ULL << 1) > > +#define ITS_WORKAROUND_CAVIUM_23144 (1ULL << 2) > > Please move this to Robert's series, as it doesn't make much sense to > add a quirk flag just to modify it in the next patch. This will help > declutter this patch. I will merge the bits in and rebase and rework this one on top (we will post this separately due to dependencies to other patch sets). Thanks, -Robert