From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbbIGMA3 (ORCPT ); Mon, 7 Sep 2015 08:00:29 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:57534 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbIGMA1 (ORCPT ); Mon, 7 Sep 2015 08:00:27 -0400 Date: Mon, 7 Sep 2015 19:56:23 +0800 From: Jisheng Zhang To: Vaibhav Hiremath CC: , , , , , Subject: Re: [PATCH-v2 1/3] mmc: sdhci-pxav3: Fix tabbing issue Message-ID: <20150907195623.479382b2@xhacker> In-Reply-To: <1441625471-16315-2-git-send-email-vaibhav.hiremath@linaro.org> References: <1441625471-16315-1-git-send-email-vaibhav.hiremath@linaro.org> <1441625471-16315-2-git-send-email-vaibhav.hiremath@linaro.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-09-07_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1509070182 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Sep 2015 17:01:09 +0530 Vaibhav Hiremath wrote: > There were some coding style issues where spaces have been used instead > of tabs, for example, in macro definitions, alignment of function > declarations/definitions, etc... > > This patch fixes all such occurrences in the code. > > Signed-off-by: Vaibhav Hiremath > --- > drivers/mmc/host/sdhci-pxav3.c | 46 +++++++++++++++++++++--------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > index 946d37f..7a07177 100644 > --- a/drivers/mmc/host/sdhci-pxav3.c > +++ b/drivers/mmc/host/sdhci-pxav3.c > @@ -39,24 +39,24 @@ > #include "sdhci.h" > #include "sdhci-pltfm.h" > > -#define PXAV3_RPM_DELAY_MS 50 > +#define PXAV3_RPM_DELAY_MS 50 > > -#define SD_CLOCK_BURST_SIZE_SETUP 0x10A > -#define SDCLK_SEL 0x100 > -#define SDCLK_DELAY_SHIFT 9 > -#define SDCLK_DELAY_MASK 0x1f > +#define SD_CLOCK_BURST_SIZE_SETUP 0x10A > +#define SDCLK_SEL 0x100 > +#define SDCLK_DELAY_SHIFT 9 > +#define SDCLK_DELAY_MASK 0x1f > > -#define SD_CFG_FIFO_PARAM 0x100 > -#define SDCFG_GEN_PAD_CLK_ON (1<<6) > -#define SDCFG_GEN_PAD_CLK_CNT_MASK 0xFF > -#define SDCFG_GEN_PAD_CLK_CNT_SHIFT 24 > +#define SD_CFG_FIFO_PARAM 0x100 > +#define SDCFG_GEN_PAD_CLK_ON (1<<6) > +#define SDCFG_GEN_PAD_CLK_CNT_MASK 0xFF > +#define SDCFG_GEN_PAD_CLK_CNT_SHIFT 24 > > -#define SD_SPI_MODE 0x108 > -#define SD_CE_ATA_1 0x10C > +#define SD_SPI_MODE 0x108 > +#define SD_CE_ATA_1 0x10C > > -#define SD_CE_ATA_2 0x10E > -#define SDCE_MISC_INT (1<<2) > -#define SDCE_MISC_INT_EN (1<<1) > +#define SD_CE_ATA_2 0x10E > +#define SDCE_MISC_INT (1<<2) > +#define SDCE_MISC_INT_EN (1<<1) > > struct sdhci_pxa { > struct clk *clk_core; > @@ -284,7 +284,7 @@ static void pxav3_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs) > * FE-2946959 > */ > if (pxa->sdio3_conf_reg) { > - u8 reg_val = readb(pxa->sdio3_conf_reg); > + u8 reg_val = readb(pxa->sdio3_conf_reg); > > if (uhs == MMC_TIMING_UHS_SDR50 || > uhs == MMC_TIMING_UHS_DDR50) { > @@ -304,20 +304,20 @@ static void pxav3_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs) > } > > static const struct sdhci_ops pxav3_sdhci_ops = { > - .set_clock = sdhci_set_clock, > - .platform_send_init_74_clocks = pxav3_gen_init_74_clocks, > - .get_max_clock = sdhci_pltfm_clk_get_max_clock, > - .set_bus_width = sdhci_set_bus_width, > - .reset = pxav3_reset, > - .set_uhs_signaling = pxav3_set_uhs_signaling, > + .set_clock = sdhci_set_clock, > + .platform_send_init_74_clocks = pxav3_gen_init_74_clocks, > + .get_max_clock = sdhci_pltfm_clk_get_max_clock, > + .set_bus_width = sdhci_set_bus_width, > + .reset = pxav3_reset, > + .set_uhs_signaling = pxav3_set_uhs_signaling, IMHO, this is not an improvement, previous style is fine and I saw such style in kernel here and there > }; > > static struct sdhci_pltfm_data sdhci_pxav3_pdata = { > - .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK > + .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK > | SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC > | SDHCI_QUIRK_32BIT_ADMA_SIZE > | SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, > - .ops = &pxav3_sdhci_ops, > + .ops = &pxav3_sdhci_ops, ditto > }; > > #ifdef CONFIG_OF