From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbbIHJ4m (ORCPT ); Tue, 8 Sep 2015 05:56:42 -0400 Received: from exsmtp01.microchip.com ([198.175.253.37]:62384 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754571AbbIHJ4j (ORCPT ); Tue, 8 Sep 2015 05:56:39 -0400 Date: Tue, 8 Sep 2015 11:56:29 +0200 From: Andrey Shvetsov To: Sudip Mukherjee CC: , , Greg Kroah-Hartman Subject: Re: [PATCH 3/5] staging: most: remove driver owner Message-ID: <20150908095628.GA5588@KAR-DK-M21181> References: <1441363926-5025-1-git-send-email-sudipm.mukherjee@gmail.com> <1441363926-5025-3-git-send-email-sudipm.mukherjee@gmail.com> <20150907121337.GA6992@KAR-DK-M21181> <20150907124621.GA16559@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150907124621.GA16559@sudip-pc> User-Agent: Mutt/1.5.23 (2014-03-12) X-Brightmail-Tracker: H4sIAAAAAAAAC+NgFprFqsTGxcLF5cOie23Du1CDS/NeJlkc6Oe3ePC+k8Xi3qdtjBb/X59mdWAJYIhizcxLyq9IYM04cGYVe8F+nopjl86zNDB+4+xi5OIQEljMKPH7eQtbFyMnB4uAikTDzfeMIDabgJ7Ew1dPWUBsEQEDibvrlrKD2MwC+RLvjs8CqxcWsJY4cewaM4jNK2Ao8b5lIiPE0KuMEuc+fGaBSAhKnJz5hAWiWUdiwe5PQM0cQLa0xPJ/HCBhTqBdPQ3fmUBsUaAbrkx4C7ZLSEBZ4s/mSWDzJQQCJZomNrBC2E4SL4++ZIOw7SQOT7/IDmHbS5xds5kdpubnrh1Q9doS21/tg7J1JLYd7GeBsG0l9syYyARhu0s8eLQcyvaVmPWwAaomSqJhwQmmCYySs5B8MwvJN7MQvlnAyLyKUdrZw083OEzXNcLZw8BQLzc5o0A3NzEzTy85P3cTIyTeVHcw3p7jfohRkoNJSZQ3ZtG7UCG+pPyUyozE4oz4otKc1OJDjBIcPEoivNfWAeV4iwsSc4sz02FSMhwcShK870FSgkWp6akVaZk5JalFEOlTjJJS4ry7QZICIH0ZpXlwuUuMolLCvDwgOZ6C1KLczBKI+C1GYY6HTEIsefl5qVJAJzIAgQbjK0ZxDkYlYd7s9SD1mXklcCe8ArqOCei6MIu3INeVJCKkpBoYD3F90TrIo3DsYrfZMQ2f+enLTjO4ct4uOlPYm6iyxvhoiPw2y0KTptrKZI/aRWfnnt6mzfWZKUHVuutBqOtfAc0vlzUqGh02Ncy7wPqvxbZQpiLrwycTg19P1jwJX2DWLXHXIdE4dN+8l2xbPG1C73SIvhe7mX7kRnFor5mW/fd5XGs8fixVYinOSDTUYi4qTgQAS1OVNS0DAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote: > On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote: > > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > > > The platform driver core will set the owner value, we do not need to do > > > it in the module. > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c > > > index 5b0a588..4481a0b 100644 > > > --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c > > > +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c > > > @@ -923,7 +923,6 @@ static struct platform_driver dim2_driver = { > > > .id_table = dim2_id, > > > .driver = { > > > .name = "hdm_dim2", > > > - .owner = THIS_MODULE, > > I cannot accept this. > > > > This change is not significant for current kernel, but we still have customers > > using kernels <= 3.10, where auto assignment of .owner does not exist. > But this patch is for 4.4-rc1, and it is not marked for stable. Then how > is it going to affect your customers who are still using <=3.10? The customers will get MOST Linux Driver of 4.x and compile it with 3.10. They'll not even see the warning, but missing owner is definitely not what they want to have. This patch prepares wasted time of cusomers expiriencing the issue and ours supporting resolving of some problem. But what we get instead? -- regards andy