From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755241AbbIHPRj (ORCPT ); Tue, 8 Sep 2015 11:17:39 -0400 Received: from smtprelay0128.hostedemail.com ([216.40.44.128]:57311 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755202AbbIHPRe (ORCPT ); Tue, 8 Sep 2015 11:17:34 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:3873:3874:4605:5007:6261:6742:7514:7875:9036:10004:10400:10471:10848:10967:11232:11658:11914:12517:12519:12740:13069:13255:13311:13357:21060:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: twist97_41c234cc4bf0e X-Filterd-Recvd-Size: 3262 Date: Tue, 8 Sep 2015 11:17:30 -0400 From: Steven Rostedt To: Sean Fu , "Eric W. Biederman" , Andrew Morton Cc: Austin S Hemmelgarn , Andrey Ryabinin , Ulrich Obergfell , Prarit Bhargava , Eric B Munson , "Paul E. McKenney" , Johannes Weiner , Thomas Gleixner , Don Zickus , Heinrich Schuchardt , David Rientjes , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success. Message-ID: <20150908111730.6a1ecca6@gandalf.local.home> In-Reply-To: References: <20150824125902.4ba11ec6@gandalf.local.home> <9CF68C3D-499C-4AFC-B890-BA5ECA284347@xmission.com> <20150825101507.4e3be4ca@gandalf.local.home> <55DCA705.8000903@gmail.com> <20150825150536.546a73e5@gandalf.local.home> <20150826163621.28d7990a@gandalf.local.home> <20150826223230.4348d936@grimm.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Sep 2015 11:11:38 +0800 Sean Fu wrote: > On Fri, Aug 28, 2015 at 11:31 AM, Sean Fu wrote: > > On Thu, Aug 27, 2015 at 4:32 PM, Sean Fu wrote: > >> On Thu, Aug 27, 2015 at 10:32 AM, Steven Rostedt wrote: > >>> On Thu, 27 Aug 2015 08:17:29 +0800 > >>> Sean Fu wrote: > >>>> strace execute result: > >>>> write(3, "1\2\0", 3) = -1 EINVAL (Invalid argument) > > If vleft > 1, "1\0 2" is treated as invalid paraments and all string > > include '\0' will be invalid. > Hi All experts, > Could you please signed off this patch? If anyone should take this, it would be Andrew. I have no issue with the patch. Eric, you had some issue, but I don't see a scenario that would depend on the current behavior. That is, what do you think would break if we put it back to the old behavior? -- Steve