From: Jiri Olsa <jolsa@redhat.com>
To: pi3orama <pi3orama@163.com>
Cc: "Wangnan (F)" <wangnan0@huawei.com>,
"kan.liang@intel.com" <kan.liang@intel.com>,
"acme@kernel.org" <acme@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lizefan@huawei.com" <lizefan@huawei.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] perf report: Fix invalid memory accessing
Date: Tue, 8 Sep 2015 15:33:02 +0200 [thread overview]
Message-ID: <20150908133302.GE2038@krava.brq.redhat.com> (raw)
In-Reply-To: <F94FEA4B-1E83-465C-82B3-2094CE9682EA@163.com>
On Tue, Sep 08, 2015 at 09:16:31PM +0800, pi3orama wrote:
SNIP
> >> Now I understand your suggestion. You mean we can build env->cpu before
> >> processing the first sample, then init al.socket using that map instead
> >
> > hum, that should be the case anyway.. features are read before events
> >
> >> of calling cpu_map__get_socket_id() unconditionally in an ad-hoc way.
> >>
> >> And I have another question that, since build_cpu_topo() and
> >> perf_event__preprocess_sample() are more or less doing similar things,
> >> why we need both of them?
> >
> > perf_event__preprocess_sample is called for each sample,
> > while build_cpu_topo is part of storing topology feature
> Sorry, what I wanted to say should be:
> cpu_map__get_socket_id() and build_cpu_topo()...
cpu_map__get_socket_id is also used by perf stat
jirka
next prev parent reply other threads:[~2015-09-08 13:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 12:51 Wang Nan
2015-09-07 13:03 ` Jiri Olsa
2015-09-07 13:08 ` Wangnan (F)
2015-09-07 13:27 ` Wangnan (F)
2015-09-08 7:37 ` Jiri Olsa
2015-09-08 8:12 ` Wangnan (F)
2015-09-08 13:13 ` Jiri Olsa
2015-09-08 13:16 ` pi3orama
2015-09-08 13:33 ` Jiri Olsa [this message]
2015-09-08 13:42 ` Liang, Kan
2015-09-08 15:18 ` Arnaldo Carvalho de Melo
2015-09-08 15:34 ` Jiri Olsa
[not found] ` <20150908154910.GN3475@kernel.org>
2015-09-08 15:58 ` Arnaldo Carvalho de Melo
2015-09-08 16:13 ` Arnaldo Carvalho de Melo
2015-09-08 16:35 ` Arnaldo Carvalho de Melo
2015-09-09 16:06 ` Arnaldo Carvalho de Melo
2015-09-09 16:46 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908133302.GE2038@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome