From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755199AbbIHPxG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 11:53:06 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:56233 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754664AbbIHPxD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 11:53:03 -0400
Date: Tue, 8 Sep 2015 10:52:57 -0500
From: Felipe Balbi <balbi@ti.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
CC: Felipe Balbi <balbi@ti.com>, <stern@rowland.harvard.edu>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Masanari Iida <standby24x7@gmail.com>, <pmladek@suse.cz>,
        <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: similar files: fusbh200-hcd.c and fotg210-hcd.c
Message-ID: <20150908155257.GE25074@saruman.tx.rr.com>
Reply-To: <balbi@ti.com>
References: <CA+MoWDp-rLL8tq3j0wKszwY2c-kN3fKGexguCH9MgPtHvQOjXQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="CGDBiGfvSTbxKZlW"
Content-Disposition: inline
In-Reply-To: <CA+MoWDp-rLL8tq3j0wKszwY2c-kN3fKGexguCH9MgPtHvQOjXQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--CGDBiGfvSTbxKZlW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 07, 2015 at 04:47:45PM +0200, Peter Senna Tschudin wrote:
> I executed a clone detection tool* on drivers source code and I found
> that the files
>=20
> drivers/usb/host/fusbh200-hcd.c
>=20
> and
>=20
> drivers/usb/host/fotg210-hcd.c
>=20
> are very similar. The main difference between the two files are
> replacing the string 'USBH20' by 'OTG21' and some white space fixes.
> Some changes are being applied to only one of the files, such as the
> commit f848a88d223cafa43cb318839a1171b498cf5ec8 that changes
> fotg210-hcd.c but not fusbh200-hcd.c.
>=20
> Should these files be consolidated? And if so how?

if you can find an easy way, that would be a very, very welcome patch.

--=20
balbi

--CGDBiGfvSTbxKZlW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJV7wRZAAoJEIaOsuA1yqREoLsQAJaNchnQEJYc1ALB4jWRHTfj
VhNQXnHmhhbtw97z0Ti/vk47Yuc4wSpQZ5EwsJAk6c9vGrQVoyJznJ3hu+WWwYzL
gyTIzkEEmGQvvtSgbZSBuI+fkztPxrFYZMOa5FXRg8lyZRhTRdB7nv0qKLneB1Hr
2Dkuqirsoa5Rc9WfA5I0owV/b1udd4OmaD7NkzoaLAJs8JWL/duYu8J6btn/figJ
VX263qkxLWt4tDTkEmfuTJvPZ1hCBpUbqe/GCVFcz2m2ROLt2bJc+wBus1Ps2Fv5
ZfOgsY7vAO/ZtTyYCmyw4In9Ct0ZhoHi+wZTumb/ODvKrDRsr7a0kKuaFwT9kwwl
k6VESdvGUYthWTa2YBgMfFoDsNse6Z0GZdG+8QmENpuKOlkUwtwGbjHnfitAGfR2
nuP4N/deonPUgRK3frWs8cNQZpIc0lxwSK620idmJU1cdmIo3XcftG+yBNTViPfZ
DHxG/u+OJ2K3qjPfove3Wo/pM6WAmVGcY9nunCxhvn8epF7/Hi5M1VoAMcx/eG2w
fZ5g+/RHs1CRCCe0uevz2WgXWS1v0k2ZBU/Y1bre7YskSLsDP7jZsi/NQJtgrwVo
rFAe8m8pDKswON3SeRLf+e3xJX5xIeZIuG1ktvIWdeVfD5BKXnOdswNOr6ADIHlV
m6XgrEccxXSKmnHRoAk8
=iyaP
-----END PGP SIGNATURE-----

--CGDBiGfvSTbxKZlW--