From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755356AbbIHQUu (ORCPT ); Tue, 8 Sep 2015 12:20:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46301 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755156AbbIHQUt (ORCPT ); Tue, 8 Sep 2015 12:20:49 -0400 Date: Tue, 8 Sep 2015 18:20:47 +0200 From: Jiri Olsa To: Andi Kleen Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Message-ID: <20150908162047.GK2038@krava.brq.redhat.com> References: <1441406717-1717-1-git-send-email-andi@firstfloor.org> <1441406717-1717-3-git-send-email-andi@firstfloor.org> <20150907121441.GE5806@krava.brq.redhat.com> <20150908160317.GF4524@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150908160317.GF4524@tassilo.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 09:03:17AM -0700, Andi Kleen wrote: > > - introduce the print_metrics interface for perf_stat__print_shadow_stats > > - introduce printout function > > - introduce support for printing metrics in csv in interval mode > > That's already a separate patch. > > > - and enable i > > > > > > or any other way you find feasible *easy to review*.. I cannot ack it at this state > > Well it's just printing out values. It's really not rocket science. Nobody > is asking you to review a new VM subsystems or something like that. right, it's easy.. and it should be done in 'easy to review' way > > I expect each more "refactoring" to add more problems. It's just really hard to to do, > and usually adds more problems. yep, that's why we test things > > I can try one more time, but if it doesn't work out we'll have to give up on this. ok jirka