From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755453AbbIHQsk (ORCPT ); Tue, 8 Sep 2015 12:48:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49673 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753454AbbIHQsh (ORCPT ); Tue, 8 Sep 2015 12:48:37 -0400 Date: Tue, 8 Sep 2015 09:48:37 -0700 From: Greg Kroah-Hartman To: Andrey Shvetsov Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] staging: most: remove driver owner Message-ID: <20150908164837.GB4252@kroah.com> References: <1441363926-5025-1-git-send-email-sudipm.mukherjee@gmail.com> <1441363926-5025-3-git-send-email-sudipm.mukherjee@gmail.com> <20150907121337.GA6992@KAR-DK-M21181> <20150907124621.GA16559@sudip-pc> <20150908095628.GA5588@KAR-DK-M21181> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150908095628.GA5588@KAR-DK-M21181> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 11:56:29AM +0200, Andrey Shvetsov wrote: > On Mon, Sep 07, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote: > > On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote: > > > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > > > > The platform driver core will set the owner value, we do not need to do > > > > it in the module. > > > > > > > > Signed-off-by: Sudip Mukherjee > > > > --- > > > > drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c > > > > index 5b0a588..4481a0b 100644 > > > > --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c > > > > +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c > > > > @@ -923,7 +923,6 @@ static struct platform_driver dim2_driver = { > > > > .id_table = dim2_id, > > > > .driver = { > > > > .name = "hdm_dim2", > > > > - .owner = THIS_MODULE, > > > I cannot accept this. > > > > > > This change is not significant for current kernel, but we still have customers > > > using kernels <= 3.10, where auto assignment of .owner does not exist. > > But this patch is for 4.4-rc1, and it is not marked for stable. Then how > > is it going to affect your customers who are still using <=3.10? > The customers will get MOST Linux Driver of 4.x and compile it with 3.10. Really? If they do that they are on their own and odds are, it will break. > They'll not even see the warning, but missing owner is definitely not what they > want to have. This patch prepares wasted time of cusomers expiriencing the > issue and ours supporting resolving of some problem. But what we get instead? We do not support people taking a kernel driver from one kernel and putting it into another one. That's never been something that anyone can ever do with Linux, sorry. The patch is correct. greg k-h