From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbbIHUSN (ORCPT ); Tue, 8 Sep 2015 16:18:13 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:59860 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbbIHUSJ (ORCPT ); Tue, 8 Sep 2015 16:18:09 -0400 Date: Tue, 8 Sep 2015 23:17:25 +0300 From: Mikko Rapeli To: tglx@linutronix.de, peterz@infradead.org, mingo@kernel.org, bp@alien8.de, dvlasenk@redhat.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, brgerst@gmail.com, oleg@redhat.com, hpa@zytor.com, luto@amacapital.net Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/headers] x86/headers: Remove references on the kernel side Message-ID: <20150908201725.GH9187@lakka.kapsi.fi> References: <1441438363-9999-16-git-send-email-mingo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Tested these changes on top of my uapi headers fix branch and they compile without problems in userspace and thus fix the original issue. Also abi-compliance-checker reports that these changes don't break anything in i386 ABI (details at [2]): "Test Info Library Name kernel Version #1 headers_test_v04 Version #2 headers_test_v04+test_ingo_x86_cleanup CPU Type x86 GCC Version 5.2.1 Subject Binary Compatibility Test Results Total Header Files 767 Total Shared Libraries 0 (not analyzed) Total Symbols / Types 62 / 67 Verdict Compatible" or API: "Test Info Library Name kernel Version #1 headers_test_v04 Version #2 headers_test_v04+test_ingo_x86_cleanup CPU Type x86 GCC Version 5.2.1 Subject Source Compatibility Test Results Total Header Files 767 Total Shared Libraries 0 (not analyzed) Total Symbols / Types 96 / 101 Verdict Compatible" While abi-compliance-checker is still quite broken with kernel header files[3] addition of new constants was correctly detected: "Other Changes in Constants (3) sigcontext.h [−] _fpstate Change Effect 1 The constant _fpstate with value _fpstate_32 has been added. No effect. [−] _fpstate_ia32 Change Effect 1 The constant _fpstate_ia32 with value _fpstate_32 has been added. No effect. [−] sigcontext_ia32 Change Effect 1 The constant sigcontext_ia32 with value sigcontext_32 has been added. No effect." So for 32 bit userspace side Tested-by: Mikko Rapeli -Mikko [1] http://lvc.github.io/abi-compliance-checker/ [2] API/ABI check results https://mcfrisk.kapsi.fi/temp/headers_test_v04_to_headers_test_v04+test_ingo_x86_cleanup/ [3] abi checker still has some issues with kernel headers: https://mcfrisk.kapsi.fi/temp/headers_test_v04+test_ingo_x86_cleanup/log.txt