From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbbIHWTd (ORCPT ); Tue, 8 Sep 2015 18:19:33 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:34031 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbbIHWTa (ORCPT ); Tue, 8 Sep 2015 18:19:30 -0400 Date: Tue, 8 Sep 2015 23:19:13 +0100 From: Russell King - ARM Linux To: Maxime Coquelin Cc: Arnd Bergmann , olof@lixom.net, khilman@kernel.org, afaerber@suse.de, u.kleine-koenig@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if ARM_SINGLE_ARMV7M Message-ID: <20150908221912.GE21084@n2100.arm.linux.org.uk> References: <1441744686-20521-1-git-send-email-mcoquelin.stm32@gmail.com> <1441744686-20521-2-git-send-email-mcoquelin.stm32@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441744686-20521-2-git-send-email-mcoquelin.stm32@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 10:38:04PM +0200, Maxime Coquelin wrote: > This patch makes FORCE_MAX_ZONEORDER configurable in defconfig for ARMV7-M > when built for a single platform. I'd prefer if we didn't do this, because this isn't supposed to be a user visible "option". It's an option that was introduced to avoid having to throw masses of #ifdefs into the definition of MAX_ZONEORDER. The problem with it is that it's a "well, what do I set this to?" option and that leads to "oh, I'll just choose the default because I don't know any better". Do we know why EFM32 needs a value of 9 here? It's not documented in the original commit, and it really _should_ have been. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.