From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753910AbbIHWpL (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 18:45:11 -0400
Received: from seldrel01.sonyericsson.com ([37.139.156.2]:15275 "EHLO
	seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753788AbbIHWpJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 18:45:09 -0400
Date: Tue, 8 Sep 2015 15:45:04 -0700
From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Andy Gross <agross@codeaurora.org>
CC: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 10/11] regulator: qcom-smd: Add support for PMA8084
Message-ID: <20150908224504.GA13472@usrtlx11787.corpusers.net>
References: <1441748131-26490-1-git-send-email-agross@codeaurora.org>
 <1441748131-26490-12-git-send-email-agross@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1441748131-26490-12-git-send-email-agross@codeaurora.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 08 Sep 14:35 PDT 2015, Andy Gross wrote:

> This patch adds support and documentation for the PMA8084 regulators
> found on APQ8084 platforms.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt   |   35 ++++++++
>  drivers/regulator/qcom_smd-regulator.c             |   95 ++++++++++++++++++++
>  2 files changed, 130 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt
[..]
> +- vdd_s1:
> +- vdd_s2:
> +- vdd_s3:
> +- vdd_s4:
> +- vdd_s5:
> +- vdd_s6:
> +- vdd_s7:
> +- vdd_s8:
> +- vdd_s9:
> +- vdd_s10:
> +- vdd_s11:
> +- vdd_s12:
> +- vdd_l1_l11:
> +- vdd_l2_l3_l4_l27:
> +- vdd_l5_l7:
> +- vdd_l6_l12_l14_l15_l26:
> +- vdd_l8:
> +- vdd_l9_l10_l13_l20_l23_l24:
> +- vdd_l16_l25:
> +- vdd_l17:
> +- vdd_l18:
> +- vdd_l19:
> +- vdd_l21:
> +- vdd_l22:

-supply

> +	Usage: optional (pma8084 only)
> +	Value type: <phandle>
> +	Definition: reference to regulator supplying the input pin, as
> +		    described in the data sheet
> +

Otherwise it looks good.


Regards,
Bjorn