From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbbIHWrm (ORCPT ); Tue, 8 Sep 2015 18:47:42 -0400 Received: from ozlabs.org ([103.22.144.67]:40683 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbbIHWrk (ORCPT ); Tue, 8 Sep 2015 18:47:40 -0400 Date: Wed, 9 Sep 2015 08:47:35 +1000 From: Paul Mackerras To: tim.gardner@canonical.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , Michael Ellerman , Leonidas Da Silva Barbosa , Herbert Xu Subject: Re: [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n Message-ID: <20150908224735.GA12791@fergus.ozlabs.ibm.com> References: <1441735991-29199-1-git-send-email-tim.gardner@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441735991-29199-1-git-send-email-tim.gardner@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 12:13:11PM -0600, tim.gardner@canonical.com wrote: > From: Tim Gardner > > commit 72cd7b44bc99 ("powerpc: Uncomment and make enable_kernel_vsx() > routine available") neglected to define an empty inline replacement for > enable_kernel_vsx() when CONFIG_VSX=n. If code that wants to call enable_kernel_vsx() is getting compiled in when CONFIG_VSX=n, that's a worry. Is this patch motivated by an actual compile failure? If so what was the failure? Paul.