From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbbIJAIJ (ORCPT ); Wed, 9 Sep 2015 20:08:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35878 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbbIJAIH (ORCPT ); Wed, 9 Sep 2015 20:08:07 -0400 Date: Wed, 09 Sep 2015 17:08:06 -0700 (PDT) Message-Id: <20150909.170806.1419774665265285481.davem@davemloft.net> To: Alexey.Brodkin@synopsys.com Cc: netdev@vger.kernel.org, sergei.shtylyov@cogentembedded.com, peppe.cavallaro@st.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v4] stmmac: fix check for phydev being open From: David Miller In-Reply-To: <1441810868-7212-1-git-send-email-abrodkin@synopsys.com> References: <1441810868-7212-1-git-send-email-abrodkin@synopsys.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Sep 2015 17:08:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexey Brodkin Date: Wed, 9 Sep 2015 18:01:08 +0300 > Current check of phydev with IS_ERR(phydev) may make not much sense > because of_phy_connect() returns NULL on failure instead of error value. > > Still for checking result of phy_connect() IS_ERR() makes perfect sense. > > So let's use combined check IS_ERR_OR_NULL() that covers both cases. > > Cc: Sergei Shtylyov > Cc: Giuseppe Cavallaro > Cc: linux-kernel@vger.kernel.org > Cc: stable@vger.kernel.org > Cc: David Miller > Signed-off-by: Alexey Brodkin Applied, thanks.