From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbbIJAVa (ORCPT ); Wed, 9 Sep 2015 20:21:30 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35973 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbbIJAV3 (ORCPT ); Wed, 9 Sep 2015 20:21:29 -0400 Date: Wed, 09 Sep 2015 17:21:27 -0700 (PDT) Message-Id: <20150909.172127.1527580619674387572.davem@davemloft.net> To: fengguang.wu@intel.com Cc: roopa@cumulusnetworks.com, kbuild-all@01.org, nikolay@cumulusnetworks.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: fix ifnullfree.cocci warnings From: David Miller In-Reply-To: <20150909225712.GA6796@lkp-nex05> References: <201509100609.fhjHrskx%fengguang.wu@intel.com> <20150909225712.GA6796@lkp-nex05> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Sep 2015 17:21:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot Date: Thu, 10 Sep 2015 06:57:12 +0800 > net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Roopa Prabhu > Signed-off-by: Fengguang Wu Applied, thanks.